public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: jt@hpl.hp.com, Jeff Garzik <jgarzik@mandrakesoft.com>
Cc: Andrzej Krzysztofowicz <ankry@green.mif.pg.gda.pl>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>,
	tori@unhappy.mine.nu, kernel list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net #9
Date: Thu, 31 May 2001 00:28:37 +0200	[thread overview]
Message-ID: <20010531002837.B21681@bug.ucw.cz> (raw)
In-Reply-To: <200105300048.CAA04583@green.mif.pg.gda.pl> <20010529180420.A14639@bougret.hpl.hp.com> <3B14493E.63F861E7@mandrakesoft.com> <20010529182506.A14727@bougret.hpl.hp.com>
In-Reply-To: <20010529182506.A14727@bougret.hpl.hp.com>; from Jean Tourrilhes on Tue, May 29, 2001 at 06:25:06PM -0700

Hi!

> > This is standard kernel cleanup that makes the resulting image smaller. 
> > These patches have been going into all areas of the kernel for quite
> > some time.
> 
> 	This doesn't make it right.

Well... It does. Code should be uniform. You may like

if (
  x == y
) {
  printf(
	"ahoj"
	);
}

style of indentation, but it is not okay in kernel.

> 	Ok, while we are on the topic : could somebody explain me why
> we can't get gcc to do that for us ? What is preventing adding a gcc

int xyzzy;

goes to BSS, while

int xyzzy = 0 

goes to DATA. That is important for some folks.

> command line flag to do exactly that ? It's not like rocket science
> (simple test) and would avoid to have tediously to go through all

It is actually not *so* easy to do it in gcc; there's patch, however.

								Pavel
-- 
I'm pavel@ucw.cz. "In my country we have almost anarchy and I don't care."
Panos Katsaloulis describing me w.r.t. patents at discuss@linmodems.org

  parent reply	other threads:[~2001-05-31 19:45 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-30  0:48 [PATCH] net #9 Andrzej Krzysztofowicz
2001-05-30  1:04 ` Jean Tourrilhes
2001-05-30  1:13   ` Jeff Garzik
2001-05-30  1:25     ` Jean Tourrilhes
2001-05-30  1:47       ` Jeff Garzik
2001-05-30  2:01         ` Jean Tourrilhes
2001-05-30  2:13           ` Jeff Garzik
2001-05-30  2:25             ` Jean Tourrilhes
2001-05-30 16:35           ` Hermann Himmelbauer
2001-05-30  2:13         ` Jean Tourrilhes
2001-05-30  2:17           ` Jeff Garzik
2001-05-30  9:33         ` Henning P. Schmiedehausen
2001-05-30 22:28       ` Pavel Machek [this message]
2001-05-30  9:32 ` Henning P. Schmiedehausen
2001-05-30 10:28   ` Andrzej Krzysztofowicz
2001-05-30 10:30   ` Keith Owens
2001-05-30 10:43     ` Henning P. Schmiedehausen
2001-05-30 10:30   ` Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010531002837.B21681@bug.ucw.cz \
    --to=pavel@suse.cz \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=ankry@green.mif.pg.gda.pl \
    --cc=jgarzik@mandrakesoft.com \
    --cc=jt@hpl.hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tori@unhappy.mine.nu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox