From: Pavel Machek <pavel@suse.cz>
To: Rasmus Andersen <rasmus@jaquet.dk>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] remove unnecessary zero initializations from aironet4500_proc.c (245ac1)
Date: Fri, 1 Jun 2001 19:02:03 +0200 [thread overview]
Message-ID: <20010601190203.A4723@bug.ucw.cz> (raw)
In-Reply-To: <20010528223103.J846@jaquet.dk>
In-Reply-To: <20010528223103.J846@jaquet.dk>; from Rasmus Andersen on Mon, May 28, 2001 at 10:31:04PM +0200
Hi!
> Hi.
>
> The following patch removes two superfluous initializations
> from aironet4500_proc.c, making the .o ~12K smaller in
> size. It applies against 245ac1 and was discovered by Adam
> Ritcher some time ago.
>
> --- linux-245-ac1-clean/drivers/net/aironet4500_proc.c Sat May 19 20:58:24 2001
> +++ linux-245-ac1/drivers/net/aironet4500_proc.c Mon May 28 22:13:26 2001
> @@ -59,7 +59,7 @@
> char proc_name[10];
> };
> static char awc_drive_info[AWC_STR_SIZE]="Zcom \n\0";
~~
When you are at cleaning, kill that ugly \0, too.
> -static char awc_proc_buff[AWC_STR_SIZE]="\0";
> +static char awc_proc_buff[AWC_STR_SIZE];
> static int awc_int_buff;
> static struct awc_proc_private awc_proc_priv[MAX_AWCS];
>
> @@ -403,7 +403,7 @@
> {0}
> };
>
> -struct ctl_table_header * awc_driver_sysctl_header = NULL;
> +struct ctl_table_header * awc_driver_sysctl_header;
>
> const char awc_procname[]= "awc5";
Pavel
--
I'm pavel@ucw.cz. "In my country we have almost anarchy and I don't care."
Panos Katsaloulis describing me w.r.t. patents at discuss@linmodems.org
prev parent reply other threads:[~2001-06-01 18:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-28 20:31 [PATCH] remove unnecessary zero initializations from aironet4500_proc.c (245ac1) Rasmus Andersen
2001-06-01 17:02 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010601190203.A4723@bug.ucw.cz \
--to=pavel@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=rasmus@jaquet.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox