From: Michael <leahcim@ntlworld.com>
To: linux-kernel@vger.kernel.org
Subject: Re: USB mouse wheel breakage was Re: Linux 2.4.5-ac5
Date: Sat, 2 Jun 2001 21:53:19 +0100 [thread overview]
Message-ID: <20010602215319.A13026@debian> (raw)
In-Reply-To: <20010601105717.A2468@debian> <991399435.4435.0.camel@phantasy> <991431152.653.0.camel@phantasy>
In-Reply-To: <991431152.653.0.camel@phantasy>
On Fri, Jun 01, 2001 at 05:32:26PM -0400, Robert M. Love wrote:
> I and another user thought the problem was in hid_input_field, but upon
> looking I now think not.
It is, check against hid.c in 2.4.5, the new code &&'s the first 2 if statements and so it
now checks non-zero HID_MAIN_INPUT_RELATIVE values for new and old being
the same, which AFAICT, they can and often will be.
Patch against ac6 reverts back to original hid.c check :-
--- ../linux.orig/drivers/usb/hid-core.c Sat Jun 2 21:47:35 2001
+++ drivers/usb/hid-core.c Sat Jun 2 21:46:00 2001
@@ -773,10 +773,11 @@
if (HID_MAIN_ITEM_VARIABLE & field->flags) {
- if ((field->flags & HID_MAIN_ITEM_RELATIVE) && !value[n])
- continue;
- if (value[n] == field->value[n])
- continue;
+ if (field->flags & HID_MAIN_ITEM_RELATIVE) {
+ if (!value[n]) continue;
+ } else {
+ if (value[n] == field->value[n]) continue;
+ }
hid_process_event(hid, field, &field->usage[n], value[n]);
continue;
}
--
Michael.
next prev parent reply other threads:[~2001-06-02 20:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-30 20:30 Linux 2.4.5-ac5 Alan Cox
2001-05-30 22:07 ` J . A . Magallon
2001-06-01 9:57 ` USB mouse wheel breakage was " Michael
2001-06-01 12:43 ` Robert M. Love
2001-06-01 21:32 ` Robert M. Love
2001-06-02 20:53 ` Michael [this message]
2001-06-04 9:31 ` Vojtech Pavlik
2001-06-01 14:31 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010602215319.A13026@debian \
--to=leahcim@ntlworld.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox