From: James Bottomley <James.Bottomley@SteelEye.com>
To: linux-kernel@vger.kernel.org
Subject: [PATCH] fix for initrd panic in 2.4.5
Date: Wed, 06 Jun 2001 00:08:21 -0400 [thread overview]
Message-ID: <200106060408.AAA03634@localhost.localdomain> (raw)
[-- Attachment #1: Type: text/plain, Size: 375 bytes --]
Not many people have seen this, but the i_bdev field in fake_inode in
ioctl_by_bdev() is uninitialised. Since this field is dereferenced by
BLKFLSBUF in rd_ioctl, it can lead to a panic (depending on what happens to be
on the stack). The attached fixes the problem and clears all the fields in
fake_inode to make any other problems like this show up.
James Bottomley
[-- Attachment #2: linux-2.4.5-initrd.diff --]
[-- Type: text/plain , Size: 768 bytes --]
Index: fs/block_dev.c
===================================================================
RCS file: /home/jejb/CVSROOT/linux/2.4/fs/block_dev.c,v
retrieving revision 1.1.1.10
diff -u -r1.1.1.10 block_dev.c
--- fs/block_dev.c 2001/05/26 15:33:37 1.1.1.10
+++ fs/block_dev.c 2001/06/02 13:14:35
@@ -596,13 +596,14 @@
int ioctl_by_bdev(struct block_device *bdev, unsigned cmd, unsigned long arg)
{
kdev_t rdev = to_kdev_t(bdev->bd_dev);
- struct inode inode_fake;
+ struct inode inode_fake = { 0 };
int res;
mm_segment_t old_fs = get_fs();
if (!bdev->bd_op->ioctl)
return -EINVAL;
inode_fake.i_rdev=rdev;
+ inode_fake.i_bdev = bdev;
init_waitqueue_head(&inode_fake.i_wait);
set_fs(KERNEL_DS);
res = bdev->bd_op->ioctl(&inode_fake, NULL, cmd, arg);
next reply other threads:[~2001-06-06 4:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-06 4:08 James Bottomley [this message]
2001-06-06 16:03 ` [PATCH] fix for initrd panic in 2.4.5 Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200106060408.AAA03634@localhost.localdomain \
--to=james.bottomley@steeleye.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox