From: Dawson Engler <engler@csl.Stanford.EDU>
To: torvalds@transmeta.com (Linus Torvalds)
Cc: viro@math.psu.edu (Alexander Viro), linux-kernel@vger.kernel.org
Subject: Re: [CHECKER] a couple potential deadlocks in 2.4.5-ac8
Date: Sat, 9 Jun 2001 19:28:11 -0700 (PDT) [thread overview]
Message-ID: <200106100228.TAA18829@csl.Stanford.EDU> (raw)
In-Reply-To: <Pine.LNX.4.21.0106091148380.26187-100000@penguin.transmeta.com> from "Linus Torvalds" at Jun 09, 2001 12:01:01 PM
> On Sat, 9 Jun 2001, Alexander Viro wrote:
> >
> > Another difference from spinlocks is that BKL is recursive. I'm
> > actually surprised that it didn't show up first.
>
> Good point. Spinlocks (with the exception of read-read locks, of course)
> and semaphores will deadlock on recursive use, while the BKL has this
> "process usage counter" recursion protection.
Actually, it did show up all over the place --- I'd just selected two
candidates to examine out of hundreds. (Checking call chains is
strenous, even when you know what you're looking for.)
> And I suspect that the current checker doesn't realize that any user mode
> access is equivalent to calling "do_page_fault()" from a call-chain
> standpoint.
>
> Dawson - the user-mode access part is probably _the_ most interesting from
> a lock checking standpoint, could you check doing the page fault case?
Sure, it's a pretty interaction. To be sure about the rule: any *_user
call can be treated as an implicit invocation of do_page_fault?
Dawson
next prev parent reply other threads:[~2001-06-10 2:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-09 7:59 [CHECKER] a couple potential deadlocks in 2.4.5-ac8 Dawson Engler
2001-06-09 8:11 ` checker suggestion Albert D. Cahalan
2001-06-10 2:04 ` Dawson Engler
2001-06-09 10:45 ` [CHECKER] a couple potential deadlocks in 2.4.5-ac8 Alexander Viro
2001-06-09 17:32 ` Linus Torvalds
2001-06-09 17:45 ` Alexander Viro
2001-06-09 19:01 ` Linus Torvalds
2001-06-09 19:33 ` David Woodhouse
2001-06-09 20:37 ` Linus Torvalds
2001-06-10 11:53 ` Rusty Russell
2001-06-10 11:59 ` David Woodhouse
2001-06-09 19:36 ` Alexander Viro
2001-06-09 20:42 ` Linus Torvalds
2001-06-09 21:44 ` Alexander Viro
2001-06-10 2:28 ` Dawson Engler [this message]
2001-06-10 6:19 ` Linus Torvalds
2001-06-10 7:45 ` Dawson Engler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200106100228.TAA18829@csl.Stanford.EDU \
--to=engler@csl.stanford.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox