From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: "Richard B. Johnson" <root@chaos.analogic.com>
Cc: Bill Pringlemeir <bpringle@sympatico.ca>, linux-kernel@vger.kernel.org
Subject: Re: Newbie idiotic questions.
Date: Sun, 17 Jun 2001 00:01:05 -0300 [thread overview]
Message-ID: <20010617000105.A940@conectiva.com.br> (raw)
In-Reply-To: <m2d78352do.fsf@sympatico.ca> <Pine.LNX.3.95.1010616212729.14170A-100000@chaos.analogic.com>
In-Reply-To: <Pine.LNX.3.95.1010616212729.14170A-100000@chaos.analogic.com>; from root@chaos.analogic.com on Sat, Jun 16, 2001 at 09:35:34PM -0400
Em Sat, Jun 16, 2001 at 09:35:34PM -0400, Richard B. Johnson escreveu:
> > [main.c, line 223]
> > if ((card->mpuout = kmalloc(sizeof(struct emu10k1_mpuout), GFP_KERNEL))
> >
> > Why is the struct type referenced for the allocation size? Why not,
> >
> > if ((card->mpuout = kmalloc(sizeof(card->mpuout), GFP_KERNEL))
> >
> > This seems to get the size for the actual object being allocated.
> >
>
> Again, you are correct. However, you may not know the history of the
> driver. Perhaps at one time the above statement was correct.
yes, and in fact this should be one of the entries in the kernel Janitor's
TODO list, please take a look at http://bazar.conectiva.com.br/~acme/TODO
and consider submitting some more things to cleanup so that people wanting
to start hacking the kernel can have some easy starting points. Also please
consider reading http://kernel-janitor.sourceforge.net
- Arnaldo
next prev parent reply other threads:[~2001-06-17 3:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-17 1:19 Newbie idiotic questions Bill Pringlemeir
2001-06-17 1:32 ` Jeff Garzik
2001-06-17 10:48 ` Daniel Phillips
2001-06-17 12:27 ` rjd
2001-06-17 15:01 ` Daniel Phillips
2001-06-17 15:08 ` Jeff Garzik
2001-06-17 15:38 ` David Flynn
2001-06-17 15:54 ` Jeff Garzik
2001-06-17 19:18 ` Geert Uytterhoeven
2001-06-17 20:08 ` Daniel Phillips
2001-06-17 20:37 ` Alexander Viro
2001-06-17 21:28 ` Daniel Phillips
2001-06-17 22:33 ` Alexander Viro
2001-06-18 9:14 ` Roman Zippel
2001-06-18 9:30 ` Alexander Viro
2001-06-17 21:17 ` Bill Pringlemeir
2001-06-17 1:35 ` Richard B. Johnson
2001-06-17 3:01 ` Arnaldo Carvalho de Melo [this message]
2001-06-17 8:06 ` rjd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010617000105.A940@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=bpringle@sympatico.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=root@chaos.analogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox