Re: 2.2 PATCH: check return from copy_*_user in fs/pipe.c

David S. Miller
2001-06-21T03:44:55Z

Zack Weinberg writes:
> Linus Torvalds wrote:
> > And before you say "it has to return EFAULT", check the standards, and
> > think about the case of libraries vs system calls - and how do you tell
> > them apart?
>
> My reading of the standard is that it has to either return EFAULT or
^^
> raise SIGSEGV. But I am not expert in XPG4-ese.

Linus is trying to point out: "what is this 'it'?" Is it glibc or
what the kernel gives you?

> Whether or not the standard requires anything, I would much rather
> that the kernel not silently discard error conditions.

But only perhaps from a "quality of implementation" perspective not a
"correctness" one.

Later,
David S. Miller
davem@redhat.com