Re: eepro100: wait_for_cmd_done timeout

[Masaru Kawashima <masaruk@gol.com>]

[-- Attachment #1: Type: text/plain, Size: 1258 bytes --]

Hi, again!
I'ts me, Masaru Kawashima, from home.

I'm sorry I made a stupid mistake last time!
This time, I promise you that I attach the proper patch for
linux/drivers/net/eepro100.c.  (running version)

On Thu, 21 Jun 2001 23:19:39 +0900
Masaru Kawashima <Masaru Kawashima <masaru@scji.toshiba-eng.co.jp>> wrote:

> Hi!
> 
> On Wed, 20 Jun 2001 16:31:34 -0700
> Dionysius Wilson Almeida <Dionysius Wilson Almeida <dwilson@technolunatic.com>> wrote:
> > Jun 20 16:14:07 debianlap kernel: eepro100: wait_for_cmd_done timeout!
> > Jun 20 16:14:38 debianlap last message repeated 5 times
> 
> I saw the same message.
> 
> The comment before wait_for_cmd_done() function in
> linux/drivers/net/eepro100.c says:
> /* How to wait for the command unit to accept a command.
>    Typically this takes 0 ticks. */
> 
> And the initial value for the bogus counter, named "wait", is 1000.
> Is it enough for your machine?
> 
> I applied attached patch, eepro100.patch.  After that, I've never seen
> the message from wait_for_cmd_done().  And, my NIC works fine.
> 
> You may want to adjust the initial value for the bogus counter.
> I don't know the appropriate value for this bogus counter.
> 
> I hope this helps you.
> 
> -- 
> Masaru Kawashima

--
Masaru Kawashima

[-- Attachment #2: eepro100.correct.patch --]
[-- Type: text/plain, Size: 441 bytes --]

--- linux-2.4.5/drivers/net/eepro100.c.org	Fri May 25 18:59:03 2001
+++ linux-2.4.5/drivers/net/eepro100.c	Fri Jun 22 00:55:03 2001
@@ -309,8 +309,9 @@
 static inline void wait_for_cmd_done(long cmd_ioaddr)
 {
 	int wait = 1000;
-	do   ;
-	while(inb(cmd_ioaddr) && --wait >= 0);
+	while(inb(cmd_ioaddr) && --wait >= 0){
+		udelay(1);
+	}
 #ifndef final_version
 	if (wait < 0)
 		printk(KERN_ALERT "eepro100: wait_for_cmd_done timeout!\n");