From: Arnaldo Carvalho de Melo <acme@conectiva.com.br>
To: Eric Lammerts <eric@lammerts.org>
Cc: Rasmus Andersen <rasmus@jaquet.dk>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] add kmalloc check in drviers/pcmcia/rsrc_mgr.c (245-ac16)
Date: Sat, 23 Jun 2001 14:30:06 -0300 [thread overview]
Message-ID: <20010623143006.A7004@conectiva.com.br> (raw)
In-Reply-To: <20010623152202.B840@jaquet.dk> <Pine.LNX.4.33.0106231901560.7165-100000@ally.lammerts.org>
In-Reply-To: <Pine.LNX.4.33.0106231901560.7165-100000@ally.lammerts.org>; from eric@lammerts.org on Sat, Jun 23, 2001 at 07:09:37PM +0200
Em Sat, Jun 23, 2001 at 07:09:37PM +0200, Eric Lammerts escreveu:
>
> On Sat, 23 Jun 2001, Rasmus Andersen wrote:
>
> > + if (!b) {
> > + printk(" -- aborting.\n");
> > + printk(KERN_ERR "Out of memory.");
> > + return;
> > + }
>
> Why not printk(KERN_ERR "rsrc_mgr: Out of memory.\n"); ?
> Then at least people will know what it was that ran out of memory.
Better yet:
printk(KERN_ERR __FUNCTION__ "Out of memory.");
Then if you move the code to other function or if you change the name of
the function you don't have to go all over the code doing
s/old_function_name/new_function_name/g
- Arnaldo
next prev parent reply other threads:[~2001-06-23 17:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-23 13:22 [PATCH] add kmalloc check in drviers/pcmcia/rsrc_mgr.c (245-ac16) Rasmus Andersen
2001-06-23 17:09 ` Eric Lammerts
2001-06-23 17:30 ` Arnaldo Carvalho de Melo [this message]
2001-06-24 19:46 ` Rasmus Andersen
2001-06-24 20:52 ` Eric Lammerts
2001-06-24 21:01 ` Rasmus Andersen
2001-06-24 21:09 ` Eric Lammerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010623143006.A7004@conectiva.com.br \
--to=acme@conectiva.com.br \
--cc=eric@lammerts.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rasmus@jaquet.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox