public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Dale Farnsworth" <dale@farnsworth.org>
To: Andre Hedrick <andre@aslab.com>, linux-kernel@vger.kernel.org
Subject: Patch for IDE hang after resetting quirk drive
Date: Tue, 3 Jul 2001 10:22:36 -0700	[thread overview]
Message-ID: <20010703102236.A8708@farnsworth.org> (raw)

I have a Promise PDC20265 ide controller with one of the "quirk" drives,
a Quantum Fireballp LM30.  That drive has a bad sector and accessing
it would result in a DMA timeout.  Unfortunately, after the IDE driver
resets the controller, the drive never responded.

The following patch appears to correct the problem.  It duplicates
the workaround for "quirky" drives found in ide-features.c

-Dale

Dale Farnsworth		dale@farnsworth.org

--- oldlinux-2.4.5/drivers/ide/ide.c	Tue Jul  3 09:35:57 2001
+++ linux-2.4.5/drivers/ide/ide.c	Tue Jul  3 09:23:58 2001
@@ -758,7 +758,10 @@
 	 */
 	OUT_BYTE(drive->ctl|6,IDE_CONTROL_REG);	/* set SRST and nIEN */
 	udelay(10);			/* more than enough time */
-	OUT_BYTE(drive->ctl|2,IDE_CONTROL_REG);	/* clear SRST, leave nIEN */
+	if (drive->quirk_list == 2)
+		OUT_BYTE(drive->ctl, IDE_CONTROL_REG); /* clear SRST and nIEN */
+	else
+		OUT_BYTE(drive->ctl|2,IDE_CONTROL_REG);	/* clear SRST only */
 	udelay(10);			/* more than enough time */
 	hwgroup->poll_timeout = jiffies + WAIT_WORSTCASE;
 	ide_set_handler (drive, &reset_pollfunc, HZ/20, NULL);

             reply	other threads:[~2001-07-03 17:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-07-03 17:22 Dale Farnsworth [this message]
2001-07-05  7:53 ` Patch for IDE hang after resetting quirk drive Andre Hedrick

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010703102236.A8708@farnsworth.org \
    --to=dale@farnsworth.org \
    --cc=andre@aslab.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox