From: Tim Waugh <twaugh@redhat.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: parport_pc tries to load parport_serial automatically
Date: Wed, 4 Jul 2001 13:36:34 +0100 [thread overview]
Message-ID: <20010704133634.F5254@redhat.com> (raw)
In-Reply-To: <20010626162102.F7663@redhat.com> <Pine.LNX.4.21.0106270732160.1331-100000@freak.distro.conectiva>
In-Reply-To: <Pine.LNX.4.21.0106270732160.1331-100000@freak.distro.conectiva>; from marcelo@conectiva.com.br on Wed, Jun 27, 2001 at 07:32:42AM -0300
On Wed, Jun 27, 2001 at 07:32:42AM -0300, Marcelo Tosatti wrote:
> Could you remove the request_module() from parport_pc ?
Yes.
Here is a patch against 2.4.5-ac24.
Tim.
*/
2001-07-04 Tim Waugh <twaugh@redhat.com>
* drivers/parport/parport_pc.c: Don't load parport_serial.
* drivers/parport/ChangeLog: Updated.
--- linux/drivers/parport/parport_pc.c.orig Wed Jul 4 13:30:01 2001
+++ linux/drivers/parport/parport_pc.c Wed Jul 4 13:30:26 2001
@@ -2931,11 +2931,6 @@
if (ret && registered_parport)
pci_unregister_driver (&parport_pc_pci_driver);
-#ifdef CONFIG_PARPORT_SERIAL_MODULE
- if (!ret)
- request_module ("parport_serial");
-#endif
-
return ret;
}
--- linux/drivers/parport/ChangeLog.orig Wed Jul 4 13:30:32 2001
+++ linux/drivers/parport/ChangeLog Wed Jul 4 13:32:01 2001
@@ -0,0 +1,6 @@
+2001-07-04 Tim Waugh <twaugh@redhat.com>
+
+ * parport_pc.c (init_module): Don't try to load parport_serial.
+ This means that the user needs to load it (or a hardware detection
+ program on their behalf) if necessary.
+
next prev parent reply other threads:[~2001-07-04 12:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-26 6:17 parport_pc tries to load parport_serial automatically Marcelo Tosatti
2001-06-26 9:23 ` Tim Waugh
2001-06-26 12:55 ` Simon Huggins
2001-06-26 12:56 ` Simon Huggins
2001-06-26 13:37 ` Keith Owens
2001-06-26 13:53 ` Tim Waugh
2001-06-26 14:34 ` Keith Owens
2001-06-26 13:30 ` Marcelo Tosatti
2001-06-26 15:21 ` Tim Waugh
2001-06-27 10:32 ` Marcelo Tosatti
2001-07-04 12:36 ` Tim Waugh [this message]
2001-07-04 12:38 ` Alan Cox
2001-07-04 12:38 ` Tim Waugh
2001-06-26 17:59 ` Philip Blundell
2001-06-26 19:50 ` Tim Waugh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010704133634.F5254@redhat.com \
--to=twaugh@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox