public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrea Arcangeli <andrea@suse.de>
To: Andrew Morton <andrewm@uow.edu.au>
Cc: Dan Kegel <dank@kegel.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: O_DIRECT please; Sybase 12.5
Date: Thu, 5 Jul 2001 16:37:16 +0200	[thread overview]
Message-ID: <20010705163716.R17051@athlon.random> (raw)
In-Reply-To: <3B3C4CB4.6B3D2B2F@kegel.com>, <3B3C4CB4.6B3D2B2F@kegel.com>; <20010705155350.O17051@athlon.random> <3B44797F.DD9EAC99@uow.edu.au>
In-Reply-To: <3B44797F.DD9EAC99@uow.edu.au>; from andrewm@uow.edu.au on Fri, Jul 06, 2001 at 12:28:15AM +1000

On Fri, Jul 06, 2001 at 12:28:15AM +1000, Andrew Morton wrote:
> ext3 journals data.  That's unique and it breaks things (or rather,
> things break it).   It'd be trivial to support O_DIRECT in ext3's
> writeback mode (metadata-only), but nobody uses that.

I thought everybody uses metadata-only to avoid killing data-write
performance. So I thought it was ok to at first support O_DIRECT only
for metadata journaling, doing that should be a three liner as you said
and that is what I expected.

> >From a quick look it seems that we'll need fs-private implementations
> of generic_direct_IO() and brw_kiovec() at least.

brw_kiovec is called by generic_direct_IO, so yes, all you need is a
private generic_direct_IO implementation to deal with the journaled data
writes.

> I'll take a closer look.

OK, thanks!

Andrea

  reply	other threads:[~2001-07-05 14:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-06-29  9:39 O_DIRECT please; Sybase 12.5 Dan Kegel
2001-06-29  9:50 ` Alan Cox
2001-06-29 10:16   ` Dan Kegel
2001-06-29 12:49     ` Mike Harrold
2001-07-05 13:59   ` Andrea Arcangeli
2001-06-29 15:23 ` Steve Lord
2001-07-03  9:42 ` Stephen C. Tweedie
2001-07-03 15:10   ` Daryll Strauss
2001-07-03 15:48     ` Stephen C. Tweedie
2001-07-05 13:53 ` Andrea Arcangeli
2001-07-05 14:28   ` Andrew Morton
2001-07-05 14:37     ` Andrea Arcangeli [this message]
2001-07-05 15:06       ` Andrew Morton
2001-07-06  0:25         ` Keith Owens
     [not found] <3B3C4CB4.6B3D2B2F@kegel.com.suse.lists.linux.kernel>
2001-06-29 10:42 ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010705163716.R17051@athlon.random \
    --to=andrea@suse.de \
    --cc=andrewm@uow.edu.au \
    --cc=dank@kegel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox