Re: linux/macros.h(new) and linux/list.h(mod) ...

Kai Germaschewski
2001-07-05T22:10:55Z

On Thu, 5 Jul 2001, Davide Libenzi wrote:

> This patch add a new linux/macros.h that is supposed to host utility macros
> that otherwise developers are forced to define in their files.
> This version contain only min(), max() and abs().

It's a good old tradition to put macros in uppercase letters. This would
have avoided one fatal error in your patch, the conflict with the gcc
built-in

int abs(int);

which has it's prototype in include/linux/kernel.h. There's places which
depend on this and would break with your macro.

Also, unless you have more macros in mind, it may make sense to just place
MIN, MAX in kernel.h and of course to remove similar macro definitions
throughout the kernel and replace them by the commonly defined ones.

--Kai