Re: [Ext2-devel] Re: 2.4.6 and ext3-2.4-0.9.1-246

Stephen C. Tweedie
2001-07-16T18:23:40Z

Hi,

On Sat, Jul 14, 2001 at 09:58:42PM +1000, Andrew Morton wrote:

> OK, there was a nasty bug in 0.9.1 which I was not able to trigger
> in a solid month's testing. But others with more worthy hardware
> were able to find it quite quickly.

It would depend very much on the workload. The problem would only
occur if you had two tasks collide when trying to allocate a block at
the same time, which essentially means doing mmap writes in the middle
of a sparse file. Most workloads would not ever trigger that no
matter how much you tried.

> Stephen fixed it in 0.9.2.
> I don't know if it explains the failure you saw.

Me neither, but it could conceivably do so. The worst case scenario
as an immediate result of that bug would be corruption in the middle
of an indirect block. We used to see that on ext2 on kernels before
2.4.3 as a result of a similar bug there, and the side effects of the
bug were often severe --- if an indirect block is corrupted this way,
then on subsequent delete, you can end up freeing arbitrary parts of
the fs and all bets are off beyond that.

With the 0.9.2 fix in place, I've seen no such problems with any
stress tests, although the VM problems being discussed elsewhere do
still sometimes cause things to stall for a while or lock up totally
after a few hours.

Cheers,
Stephen