Re: io_request_lock patch?

Jens Axboe
2001-07-11T07:16:11Z

On Tue, Jul 10 2001, Mike Anderson wrote:
> The call to do_aic7xxx_isr appears that you are running the aic7xxx_old.c
> code. This driver is using the io_request_lock to protect internal data.
> The newer aic driver has its own lock. This is related to previous
> comments by Jens and Eric about lower level use of this lock.

Yes

> I would like to know why the request_freelist is going empty? Having

Well, it's a limited resource so it's bound to go empty when under load.
In fact, if you have plenty of RAM this is what will end up starting I/O
on the queued buffers. With the batch freeing of request slots, this is
ok.

> __get_request_wait being called alot would appear to be not optimal.

?? Care to explain your reasoning behind this statement.

--
Jens Axboe