public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joerg Reuter <jreuter@suse.de>
To: Maksim Krasnyanskiy <maxk@qualcomm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [BUG?] vtund broken by tun driver changes in 2.4.6
Date: Fri, 13 Jul 2001 19:43:18 +0200	[thread overview]
Message-ID: <20010713194317.A18866@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.33.0107070058350.29490-100000@mackman.net.suse.lists.linux.kernel> <009601c106ff$a3cb2070$6baaa8c0@kevin.suse.lists.linux.kernel> <20010713133329.DDCEB19A57@lamarr.suse.de> <01071308585200.00792@btdemo1.qualcomm.com>
In-Reply-To: <01071308585200.00792@btdemo1.qualcomm.com>

[-- Attachment #1: Type: text/plain, Size: 1151 bytes --]

On Fri, Jul 13, 2001 at 08:58:52AM -0700, Maksim Krasnyanskiy wrote:

> Ioctls were defined _without_ IOW macros. And that was ugly. That's why I redifened them.
> So, if you recompile everything will be fine.

So you break binary compatibilty within a _stable_ kernel release just
for the sake of beauty? Besides, this does not only affect VTUND but
also other applications like Hercules. Just recompiling Hercules doesn't
help here anyway, because it (rightfully) refuses to include kernel
headers but (due to the lack of net/if_tun.h within glibc) constructs
the IOCTL command on its own.

> > And BTW, you shouldn't include kernel headers from user space programs, should you.
> That rule doesn't apply here. 

Can you tell me why it does not apply here? Just because you happen to
be the author of both the driver (which is, without doubt, very
valuable) and _one_ of several applications using it?

-- 
Joerg Reuter                                    http://yaina.de/jreuter
And I make my way to where the warm scent of soil fills the evening air. 
Everything is waiting quietly out there....                 (Anne Clark)

[-- Attachment #2: Type: application/pgp-signature, Size: 240 bytes --]

  reply	other threads:[~2001-07-13 17:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.4.33.0107070058350.29490-100000@mackman.net.suse.lists.linux.kernel>
     [not found] ` <009601c106ff$a3cb2070$6baaa8c0@kevin.suse.lists.linux.kernel>
2001-07-13 13:33   ` [BUG?] vtund broken by tun driver changes in 2.4.6 Joerg Reuter
2001-07-13 15:58     ` Maksim Krasnyanskiy
2001-07-13 17:43       ` Joerg Reuter [this message]
2001-07-13 19:44         ` Maksim Krasnyanskiy
2001-07-07  8:02 Ryan Mack
2001-07-07 16:12 ` Kevin P. Fleming

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010713194317.A18866@suse.de \
    --to=jreuter@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxk@qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox