From: duane voth <duanev@interactivesi.com>
To: "Benjamin C.R. LaHaise" <blah@kvack.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: bug in asm/rwlock.h?
Date: Mon, 16 Jul 2001 18:44:37 -0500 [thread overview]
Message-ID: <20010716184437.A11947@interactivesi.com> (raw)
I was looking at the symetry in rwlock.h and noticed this:
#define __build_read_lock_ptr(rw, helper) \
asm volatile(LOCK "subl $1,(%0)\n\t" \
....
#define __build_read_lock_const(rw, helper) \
asm volatile(LOCK "subl $1,%0\n\t" \
....
#define __build_write_lock_ptr(rw, helper) \
asm volatile(LOCK "subl $" RW_LOCK_BIAS_STR ",(%0)\n\t" \
....
#define __build_write_lock_const(rw, helper) \
asm volatile(LOCK "subl $" RW_LOCK_BIAS_STR ",(%0)\n\t" \
....
Why is %0 used indirectly in __build_write_lock_const?
Shouldn't it be
asm volatile(LOCK "subl $" RW_LOCK_BIAS_STR ",%0\n\t" \
like in __build_read_lock_const?
It doesn't look like many people use __build_write_lock_const.
duane
reply other threads:[~2001-07-17 17:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010716184437.A11947@interactivesi.com \
--to=duanev@interactivesi.com \
--cc=blah@kvack.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox