public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* bug in asm/rwlock.h?
@ 2001-07-16 23:44 duane voth
  0 siblings, 0 replies; only message in thread
From: duane voth @ 2001-07-16 23:44 UTC (permalink / raw)
  To: Benjamin C.R. LaHaise, lkml

I was looking at the symetry in rwlock.h and noticed this:

	#define __build_read_lock_ptr(rw, helper)   \
		asm volatile(LOCK "subl $1,(%0)\n\t" \
		....

	#define __build_read_lock_const(rw, helper)   \
		asm volatile(LOCK "subl $1,%0\n\t" \
		....

	#define __build_write_lock_ptr(rw, helper) \
		asm volatile(LOCK "subl $" RW_LOCK_BIAS_STR ",(%0)\n\t" \
		....

	#define __build_write_lock_const(rw, helper) \
		asm volatile(LOCK "subl $" RW_LOCK_BIAS_STR ",(%0)\n\t" \
		....


Why is %0 used indirectly in __build_write_lock_const?
Shouldn't it be

		asm volatile(LOCK "subl $" RW_LOCK_BIAS_STR ",%0\n\t" \

like in __build_read_lock_const?

It doesn't look like many people use __build_write_lock_const.

duane


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2001-07-17 17:21 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-07-16 23:44 bug in asm/rwlock.h? duane voth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox