public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Stephen C. Tweedie" <sct@redhat.com>
To: Andrew Morton <andrewm@uow.edu.au>
Cc: Mike Black <mblack@csihq.com>,
	"Stephen C. Tweedie" <sct@redhat.com>,
	"linux-kernel@vger.kernel.or" <linux-kernel@vger.kernel.org>,
	ext2-devel@lists.sourceforge.net
Subject: Re: [Ext2-devel] Re: 2.4.6 and ext3-2.4-0.9.1-246
Date: Mon, 16 Jul 2001 19:23:05 +0100	[thread overview]
Message-ID: <20010716192305.F28023@redhat.com> (raw)
In-Reply-To: <3B4C729B.6352A443@uow.edu.au> <05c401c10ac1$0e81ad70$e1de11cc@csihq.com> <3B4D8B5D.E9530B60@uow.edu.au> <036e01c10b96$72ce57d0$e1de11cc@csihq.com> <111501c10ba3$664a1370$e1de11cc@csihq.com> <3B4F0273.1DF40F8E@uow.edu.au> <125101c10bc1$85eab630$e1de11cc@csihq.com> <20010713183800.J13419@redhat.com> <001101c10c51$bd6239e0$b6562341@cfl.rr.com> <3B5033F2.AF71624E@uow.edu.au>
In-Reply-To: <3B5033F2.AF71624E@uow.edu.au>; from andrewm@uow.edu.au on Sat, Jul 14, 2001 at 09:58:42PM +1000

Hi,

On Sat, Jul 14, 2001 at 09:58:42PM +1000, Andrew Morton wrote:

> OK, there was a nasty bug in 0.9.1 which I was not able to trigger
> in a solid month's testing.  But others with more worthy hardware
> were able to find it quite quickly.

It would depend very much on the workload.  The problem would only
occur if you had two tasks collide when trying to allocate a block at
the same time, which essentially means doing mmap writes in the middle
of a sparse file.  Most workloads would not ever trigger that no
matter how much you tried.  

> Stephen fixed it in 0.9.2.
> I don't know if it explains the failure you saw.

Me neither, but it could conceivably do so.  The worst case scenario
as an immediate result of that bug would be corruption in the middle
of an indirect block.  We used to see that on ext2 on kernels before
2.4.3 as a result of a similar bug there, and the side effects of the
bug were often severe --- if an indirect block is corrupted this way,
then on subsequent delete, you can end up freeing arbitrary parts of
the fs and all bets are off beyond that.

With the 0.9.2 fix in place, I've seen no such problems with any
stress tests, although the VM problems being discussed elsewhere do
still sometimes cause things to stall for a while or lock up totally
after a few hours.

Cheers,
 Stephen

  reply	other threads:[~2001-07-16 18:23 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-07-10  9:47 2.4.6 and ext3-2.4-0.9.1-246 Mike Black
2001-07-10 17:52 ` Andreas Dilger
     [not found]   ` <018101c1096a$17e2afc0$b6562341@cfl.rr.com>
2001-07-10 18:17     ` [Ext2-devel] " Stephen C. Tweedie
2001-07-10 18:27       ` Mike Black
2001-07-10 18:29         ` Stephen C. Tweedie
2001-07-10 18:51     ` Andreas Dilger
2001-07-11  4:08 ` Andrew Morton
2001-07-11 12:16   ` Mike Black
2001-07-11 15:36     ` Andrew Morton
2001-07-12 10:54       ` Mike Black
2001-07-12 11:34         ` Andrew Morton
2001-07-13 12:22           ` Mike Black
2001-07-13 13:54             ` Mike Black
2001-07-13 14:15               ` Andrew Morton
2001-07-13 17:30                 ` Mike Black
2001-07-13 17:38                   ` [Ext2-devel] " Stephen C. Tweedie
2001-07-14 10:42                     ` Mike Black
2001-07-14 10:53                       ` Andrew Morton
2001-07-14 11:58                       ` Andrew Morton
2001-07-16 18:23                         ` Stephen C. Tweedie [this message]
2001-07-13 16:30               ` Stephen C. Tweedie
2001-07-13 17:27                 ` Steve Lord
2001-07-13 17:33                   ` Stephen C. Tweedie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010716192305.F28023@redhat.com \
    --to=sct@redhat.com \
    --cc=andrewm@uow.edu.au \
    --cc=ext2-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mblack@csihq.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox