Re: [PATCH] 2.4.7-ac2 :fs/jffs2/background.c

Re: [PATCH] 2.4.7-ac2 :fs/jffs2/background.c

[Frank Davis]

Hello all,
   The patch I sent regarding fs/jffs2/background.c compiled, however, further testing of the patch made me realize that complete_and_exit requires a struct completion, not struct semaphore. I added a struct completion gc_thread_sem_comp to jffs2_sb_info and added #include <linux/completion.h> to include/linux/jffs2_fs_sb.h ...When I re-ran 'make modules' , drivers/ieee1394/ieee1394_core.o didn't compile....a "completion reference error" occurred. Without the change to jffs2_fs_sb.h , ieee1394 and jffs2 compiled. Are there dependencies between ieee1394 and jffs2 ? I wouldn't believe that there would. 
Regards,
Frank

-- 

[PATCH] 2.4.7-ac2 : fs/jffs2/background.c

[Frank Davis]

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

Hello all,
    I have attached a patch that should fix the problem.
Regards,
Frank

On Sat, 28 Jul 2001 01:35:22 -0400 (EDT) Frank Davis
<fdavis@andrew.cmu.edu> writes:
> Hello all,
>    Towards the end of 'make modules_install'  in 2.4.7-ac2 , I 
> received
> the following error:
> 
> depmod: *** Unresolved symbols in
> /lib/modules/2.4.7-ac2/kernel/fs/jffs2/jffs2.o
> depmod:  up_and_exit
> 
> up_and_exit is used in fs/jffs2/background.c 
> 
> Regards,
> Frank
> 
> 

[-- Attachment #2: Backgrou --]
[-- Type: application/octet-stream, Size: 459 bytes --]

--- fs/jffs2/background.c.old	Sat Jul 28 00:26:10 2001
+++ fs/jffs2/background.c	Sat Jul 28 01:51:06 2001
@@ -140,7 +140,7 @@
 				spin_lock_bh(&c->erase_completion_lock);
                                 c->gc_task = NULL;
 				spin_unlock_bh(&c->erase_completion_lock);
-				up_and_exit(&c->gc_thread_sem, 0);
+				complete_and_exit(&c->gc_thread_sem, 0);
 
 			case SIGHUP:
 				D1(printk(KERN_DEBUG "jffs2_garbage_collect_thread(): SIGHUP received.\n"));