From: Andrea Arcangeli <andrea@suse.de>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Kernel diff_small_2.4.8pre2_2.4.8pre3
Date: Tue, 31 Jul 2001 05:58:44 +0200 [thread overview]
Message-ID: <20010731055844.A25719@athlon.random> (raw)
In-Reply-To: <200107301808.f6UI8DL29566@athlon.random>
In-Reply-To: <200107301808.f6UI8DL29566@athlon.random>; from andrea@athlon.random on Mon, Jul 30, 2001 at 08:08:13PM +0200
On Mon, Jul 30, 2001 at 08:08:13PM +0200, Andrea Arcangeli wrote:
> diff -urN 2.4.8pre2/include/asm-i386/softirq.h 2.4.8pre3/include/asm-i386/softirq.h
> --- 2.4.8pre2/include/asm-i386/softirq.h Sun Jul 29 06:02:41 2001
> +++ 2.4.8pre3/include/asm-i386/softirq.h Mon Jul 30 20:07:54 2001
> @@ -28,8 +28,6 @@
> unsigned long flags; \
> \
> __save_flags(flags); \
> - if (!(flags & (1 << 9))) \
> - BUG(); \
> barrier(); \
> if (!--*ptr) \
> __asm__ __volatile__ ( \
if you drop the bugcheck you should drop the __save_flags and flags too.
What was the problem with it? I seen a report from Chris but that sounds
like a bug in a caller of the the smp-call function (smp-call must be
run with irq enabled as it's written explicitly in the comment on top of
it).
Andrea
parent reply other threads:[~2001-07-31 3:58 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <200107301808.f6UI8DL29566@athlon.random>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010731055844.A25719@athlon.random \
--to=andrea@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox