From: Christoph Hellwig <hch@ns.caldera.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] kill unneeded code from mm/memory.c
Date: Thu, 2 Aug 2001 01:53:27 +0200 [thread overview]
Message-ID: <20010802015327.A28374@caldera.de> (raw)
Hi Alan,
the attached patch kills a one of the two identical conditionals
at the end of vmtruncate. This piece of code is only in -ac, btw.
Please consider applying.
Christoph
--
Of course it doesn't work. We've performed a software upgrade.
diff -uNr ../master/linux-2.4.7-ac3/mm/memory.c linux/mm/memory.c
--- ../master/linux-2.4.7-ac3/mm/memory.c Thu Aug 2 01:48:23 2001
+++ linux/mm/memory.c Thu Aug 2 01:50:12 2001
@@ -1041,17 +1041,10 @@
}
}
inode->i_size = offset;
- if (inode->i_op && inode->i_op->truncate)
- {
- /* This doesnt scale but it is meant to be a 2.4 invariant */
- lock_kernel();
- inode->i_op->truncate(inode);
- unlock_kernel();
- }
- return 0;
-
+
out_truncate:
if (inode->i_op && inode->i_op->truncate) {
+ /* This doesnt scale but it is meant to be a 2.4 invariant */
lock_kernel();
inode->i_op->truncate(inode);
unlock_kernel();
next reply other threads:[~2001-08-01 23:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-01 23:53 Christoph Hellwig [this message]
[not found] <mailman.996710160.18802.linux-kernel2news@redhat.com>
2001-08-02 1:54 ` [PATCH] kill unneeded code from mm/memory.c Pete Zaitcev
2001-08-02 8:40 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010802015327.A28374@caldera.de \
--to=hch@ns.caldera.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox