From: Andrea Arcangeli <andrea@suse.de>
To: "David S. Miller" <davem@redhat.com>
Cc: Chris Wedgwood <cw@f00f.org>,
David Luyer <david_luyer@pacific.net.au>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@transmeta.com>
Subject: Re: /proc/<n>/maps growing...
Date: Mon, 6 Aug 2001 15:29:19 +0200 [thread overview]
Message-ID: <20010806152919.H20837@athlon.random> (raw)
In-Reply-To: <997080081.3938.28.camel@typhaon> <20010806105904.A28792@athlon.random> <15214.24938.681121.837470@pizda.ninka.net> <20010806125705.I15925@athlon.random> <20010807002650.B23937@weta.f00f.org> <20010806143603.C20837@athlon.random> <20010807004510.A23992@weta.f00f.org> <20010806145052.F20837@athlon.random> <15214.38470.749251.251809@pizda.ninka.net>
In-Reply-To: <15214.38470.749251.251809@pizda.ninka.net>; from davem@redhat.com on Mon, Aug 06, 2001 at 06:06:14AM -0700
On Mon, Aug 06, 2001 at 06:06:14AM -0700, David S. Miller wrote:
> I wouldn't classify it as a horrible hack... but.
The part I find worse is that we just walk the tree two times.
I believe the best way is to allocate always the new vma, and to hide
the merging into the lowlevel of a new insert_vm_struct (with a special
function ala merge_segments that we can share with mprotect like in 2.2).
For example we could limit such special function to merge only the
anonymous mappings if we don't want to solve the locking issues (the
abortion), so it could remain simple but generic and optimized to avoid
walking the tree, allocating and freeing a slab cache is O(1) operation
when there's no memory pressore, much better than browsing a tree two
times at every malloc with a two liner that avoids hitting the
max_limit while we recall malloc. (of course for mremap we'll keep
browsing the tree twice but we cannot avoid that)
Andrea
next prev parent reply other threads:[~2001-08-06 13:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-06 6:41 /proc/<n>/maps growing David Luyer
2001-08-06 7:43 ` Chris Wedgwood
2001-08-06 8:59 ` Andrea Arcangeli
2001-08-06 9:20 ` David S. Miller
2001-08-06 9:46 ` Chris Wedgwood
2001-08-06 10:57 ` Andrea Arcangeli
2001-08-06 12:26 ` Chris Wedgwood
2001-08-06 12:36 ` Andrea Arcangeli
2001-08-06 12:45 ` Chris Wedgwood
2001-08-06 12:50 ` Andrea Arcangeli
2001-08-06 13:06 ` David S. Miller
2001-08-06 13:29 ` Andrea Arcangeli [this message]
2001-08-06 17:27 ` Linus Torvalds
2001-09-03 15:44 ` mmap-rb-7 [was Re: /proc/<n>/maps growing...] Andrea Arcangeli
2001-08-06 17:20 ` /proc/<n>/maps growing Linus Torvalds
2001-08-07 2:24 ` David Luyer
2001-08-06 17:46 ` Anton Altaparmakov
2001-08-06 16:12 ` Rik van Riel
2001-08-06 17:46 ` Linus Torvalds
2001-08-06 10:30 ` Jakub Jelinek
2001-08-06 10:49 ` Andrea Arcangeli
2001-08-06 11:01 ` Jakub Jelinek
2001-08-06 11:25 ` Andrea Arcangeli
2001-08-06 17:17 ` Linus Torvalds
2001-08-06 17:26 ` Alan Cox
2001-08-06 22:55 ` Chris Wedgwood
2001-08-06 11:16 ` Jakub Jelinek
2001-08-06 17:18 ` Linus Torvalds
-- strict thread matches above, loose matches on Subject: below --
2001-08-07 3:46 Rick Hohensee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010806152919.H20837@athlon.random \
--to=andrea@suse.de \
--cc=cw@f00f.org \
--cc=davem@redhat.com \
--cc=david_luyer@pacific.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox