From: Jens Axboe <axboe@suse.de>
To: Brent Baccala <baccala@freesoft.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-usb-devel <linux-usb-devel@lists.sourceforge.net>
Subject: Re: Problem with usb-storage using HP 8200 external CD-ROM burner
Date: Tue, 7 Aug 2001 09:33:20 +0200 [thread overview]
Message-ID: <20010807093320.I6192@suse.de> (raw)
In-Reply-To: <3B68FB0C.5BC83115@freesoft.org> <20010806014626.K24225@one-eyed-alien.net> <3B6EF4DA.8899E1D3@freesoft.org> <20010806201746.C6080@one-eyed-alien.net>
In-Reply-To: <20010806201746.C6080@one-eyed-alien.net>
On Mon, Aug 06 2001, Matthew Dharm wrote:
> > 774 spin_lock_irqsave(&io_request_lock, flags);
> > 775 rtn = SCpnt->host->hostt->eh_abort_handler(SCpnt);
> > 776 spin_unlock_irqrestore(&io_request_lock, flags);
> >
> > seems like a real shotgun approach. Get rid of the spinlock stuff, and
> > make sure that the abort handlers lock io_request_lock themselves if
> > they need it. Of course, this would require changes to all the scsi
> > drivers.
>
> Hrm... perhaps I could just unlock that spinlock and then re-lock it before
> returning. Anyone have a clue if this would work?
That would work -- stuff like the above is already scheduled for removal
for 2.5. Locking will be moved from the mid layer to the drivers
themselves.
--
Jens Axboe
next prev parent reply other threads:[~2001-08-07 7:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-02 7:02 Problem with usb-storage using HP 8200 external CD-ROM burner Brent Baccala
[not found] ` <20010806014626.K24225@one-eyed-alien.net>
2001-08-06 19:49 ` Brent Baccala
2001-08-07 3:17 ` Matthew Dharm
2001-08-07 7:33 ` Jens Axboe [this message]
2001-08-07 15:09 ` Brent Baccala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010807093320.I6192@suse.de \
--to=axboe@suse.de \
--cc=baccala@freesoft.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox