From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Tue, 7 Aug 2001 03:33:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Tue, 7 Aug 2001 03:33:46 -0400 Received: from ns.virtualhost.dk ([195.184.98.160]:45060 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id ; Tue, 7 Aug 2001 03:33:37 -0400 Date: Tue, 7 Aug 2001 09:33:20 +0200 From: Jens Axboe To: Brent Baccala , linux-kernel , linux-usb-devel Subject: Re: Problem with usb-storage using HP 8200 external CD-ROM burner Message-ID: <20010807093320.I6192@suse.de> In-Reply-To: <3B68FB0C.5BC83115@freesoft.org> <20010806014626.K24225@one-eyed-alien.net> <3B6EF4DA.8899E1D3@freesoft.org> <20010806201746.C6080@one-eyed-alien.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20010806201746.C6080@one-eyed-alien.net> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 06 2001, Matthew Dharm wrote: > > 774 spin_lock_irqsave(&io_request_lock, flags); > > 775 rtn = SCpnt->host->hostt->eh_abort_handler(SCpnt); > > 776 spin_unlock_irqrestore(&io_request_lock, flags); > > > > seems like a real shotgun approach. Get rid of the spinlock stuff, and > > make sure that the abort handlers lock io_request_lock themselves if > > they need it. Of course, this would require changes to all the scsi > > drivers. > > Hrm... perhaps I could just unlock that spinlock and then re-lock it before > returning. Anyone have a clue if this would work? That would work -- stuff like the above is already scheduled for removal for 2.5. Locking will be moved from the mid layer to the drivers themselves. -- Jens Axboe