* Compile failure: 2.2.19 + eide patch on PPC @ 2001-08-07 19:24 Mike Fedyk 2001-08-07 19:43 ` Phil Brutsche 0 siblings, 1 reply; 4+ messages in thread From: Mike Fedyk @ 2001-08-07 19:24 UTC (permalink / raw) To: linux-kernel I am trying to compile 2.2.19 + ide.2.2.19.05042001.patch. When doing this, I get the errors below. I've also tried: ide.2.2.19.03252001.patch ide.2.2.19.04092001.patch I've tried compiling on several different machines, though they were all setup with Debian 2.2. I haven't tried a 2.4.x on ppc, but I want to try to get 2.2 working. Is there another patch I need? # gcc -v Reading specs from /usr/lib/gcc-lib/powerpc-linux/2.95.2/specs gcc version 2.95.2 20000220 (Debian GNU/Linux) Error: make[3]: Entering directory /usr/src/lk2.2/2.2.19-ide-05042001/drivers/block' cc -D__KERNEL__ -I/usr/src/lk2.2/2.2.19-ide-05042001/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing -D__powerpc__ -fsigned-char -msoft-float -pipe -fno-builtin -ffixed-r2 -Wno-uninitialized -mmultiple -mstring -DEXPORT_SYMTAB -c ll_rw_blk.c In file included from ll_rw_blk.c:28: /usr/src/lk2.2/2.2.19-ide-05042001/include/asm/ide.h:53: parse error before *' /usr/src/lk2.2/2.2.19-ide-05042001/include/asm/ide.h:56: warning: function declaration isn't a prototype /usr/src/lk2.2/2.2.19-ide-05042001/include/asm/ide.h:63: parse error before *' /usr/src/lk2.2/2.2.19-ide-05042001/include/asm/ide.h:63: warning: function declaration isn't a prototype make[3]: *** [ll_rw_blk.o] Error 1 make[3]: Leaving directory /usr/src/lk2.2/2.2.19-ide-05042001/drivers/block' make[2]: *** [first_rule] Error 2 make[2]: Leaving directory /usr/src/lk2.2/2.2.19-ide-05042001/drivers/block' make[1]: *** [_subdir_block] Error 2 make[1]: Leaving directory /usr/src/lk2.2/2.2.19-ide-05042001/drivers' make: *** [_dir_drivers] Error 2 .config: # # Automatically generated make config: don't edit # # # Platform support # CONFIG_PPC=y CONFIG_6xx=y # CONFIG_8xx is not set CONFIG_PMAC=y # CONFIG_PREP is not set # CONFIG_CHRP is not set # CONFIG_ALL_PPC is not set # CONFIG_APUS is not set # CONFIG_GEMINI is not set # CONFIG_MBX is not set # CONFIG_SMP is not set # CONFIG_ALTIVEC is not set CONFIG_MACH_SPECIFIC=y CONFIG_POWERMAC=y # # General setup # CONFIG_EXPERIMENTAL=y CONFIG_MODULES=y CONFIG_MODVERSIONS=y CONFIG_KMOD=y CONFIG_PCI=y CONFIG_PCI_QUIRKS=y CONFIG_PCI_OPTIMIZE=y CONFIG_PCI_OLD_PROC=y CONFIG_NET=y CONFIG_SYSCTL=y CONFIG_SYSVIPC=y CONFIG_BSD_PROCESS_ACCT=y CONFIG_BINFMT_ELF=y CONFIG_KERNEL_ELF=y # CONFIG_BINFMT_MISC is not set # CONFIG_BINFMT_JAVA is not set # CONFIG_PARPORT is not set # CONFIG_VGA_CONSOLE is not set CONFIG_FB=y CONFIG_PMAC_PBOOK=y CONFIG_PROC_DEVICETREE=y # CONFIG_TOTALMP is not set # CONFIG_BOOTX_TEXT is not set # CONFIG_MOTOROLA_HOTSWAP is not set # # Plug and Play support # CONFIG_PNP=y # # Block devices # # CONFIG_BLK_DEV_FD is not set CONFIG_BLK_DEV_IDE=y # # Please see Documentation/ide.txt for help/info on IDE drives # # CONFIG_BLK_DEV_HD_IDE is not set CONFIG_BLK_DEV_IDEDISK=y # CONFIG_IDEDISK_MULTI_MODE is not set # CONFIG_IDEDISK_STROKE is not set CONFIG_BLK_DEV_IDECD=m # CONFIG_BLK_DEV_IDETAPE is not set CONFIG_BLK_DEV_IDEFLOPPY=m # CONFIG_BLK_DEV_IDESCSI is not set # CONFIG_IDE_TASK_IOCTL is not set # CONFIG_PKT_TASK_IOCTL is not set # CONFIG_IDE_TASK_IOCTL_DEBUG is not set # CONFIG_BLK_DEV_CMD640 is not set # CONFIG_BLK_DEV_RZ1000 is not set CONFIG_BLK_DEV_IDEPCI=y # CONFIG_IDEPCI_SHARE_IRQ is not set CONFIG_BLK_DEV_IDEDMA=y CONFIG_IDEDMA_AUTO=y # CONFIG_IDEDMA_NEW_DRIVE_LISTINGS is not set CONFIG_IDEDMA_PCI_EXPERIMENTAL=y # CONFIG_IDEDMA_PCI_WIP is not set # CONFIG_BLK_DEV_OFFBOARD is not set # CONFIG_BLK_DEV_AEC62XX is not set # CONFIG_BLK_DEV_ALI15X3 is not set # CONFIG_BLK_DEV_AMD74XX is not set # CONFIG_BLK_DEV_CMD64X is not set # CONFIG_BLK_DEV_CY82C693 is not set # CONFIG_BLK_DEV_CS5530 is not set # CONFIG_BLK_DEV_HPT34X is not set # CONFIG_BLK_DEV_HPT366 is not set # CONFIG_BLK_DEV_PIIX is not set # CONFIG_BLK_DEV_OPTI621 is not set CONFIG_BLK_DEV_PDC202XX=y # CONFIG_PDC202XX_BURST is not set # CONFIG_BLK_DEV_SIS5513 is not set # CONFIG_BLK_DEV_SLC90E66 is not set # CONFIG_BLK_DEV_OSB4 is not set # CONFIG_BLK_DEV_TRM290 is not set # CONFIG_BLK_DEV_VIA82CXXX is not set # CONFIG_BLK_DEV_SL82C105 is not set CONFIG_BLK_DEV_IDE_PMAC=y CONFIG_BLK_DEV_IDEDMA_PMAC=y CONFIG_BLK_DEV_IDEDMA=y CONFIG_PMAC_IDEDMA_AUTO=y # CONFIG_IDE_CHIPSETS is not set # CONFIG_IDEDMA_IVB is not set # # Additional Block Devices # CONFIG_BLK_DEV_LOOP=m # CONFIG_BLK_DEV_NBD is not set # CONFIG_BLK_DEV_MD is not set # CONFIG_BLK_DEV_RAM is not set # CONFIG_BLK_DEV_XD is not set # CONFIG_BLK_DEV_DAC960 is not set CONFIG_PARIDE_PARPORT=y # CONFIG_PARIDE is not set CONFIG_BLK_DEV_IDE_MODES=y # CONFIG_BLK_CPQ_DA is not set # CONFIG_BLK_CPQ_CISS_DA is not set # CONFIG_BLK_DEV_HD is not set # # Networking options # CONFIG_PACKET=y CONFIG_NETLINK=y CONFIG_RTNETLINK=y CONFIG_NETLINK_DEV=y CONFIG_FIREWALL=y CONFIG_FILTER=y CONFIG_UNIX=y CONFIG_INET=y # CONFIG_IP_MULTICAST is not set # CONFIG_IP_ADVANCED_ROUTER is not set # CONFIG_IP_PNP is not set # CONFIG_IP_FIREWALL is not set # CONFIG_IP_ROUTER is not set # CONFIG_NET_IPIP is not set # CONFIG_NET_IPGRE is not set CONFIG_IP_ALIAS=y # CONFIG_ARPD is not set CONFIG_SYN_COOKIES=y # # (it is safe to leave these untouched) # # CONFIG_INET_RARP is not set CONFIG_SKB_LARGE=y # CONFIG_IPV6 is not set # # # # CONFIG_IPX is not set CONFIG_ATALK=m # CONFIG_X25 is not set # CONFIG_LAPB is not set # CONFIG_BRIDGE is not set # CONFIG_NET_DIVERT is not set # CONFIG_LLC is not set # CONFIG_ECONET is not set # CONFIG_WAN_ROUTER is not set # CONFIG_NET_FASTROUTE is not set # CONFIG_NET_HW_FLOWCONTROL is not set # CONFIG_CPU_IS_SLOW is not set # # QoS and/or fair queueing # # CONFIG_NET_SCHED is not set # # SCSI support # CONFIG_SCSI=y # # SCSI support type (disk, tape, CD-ROM) # CONFIG_BLK_DEV_SD=y CONFIG_CHR_DEV_ST=y # CONFIG_CHR_DEV_OSST is not set CONFIG_BLK_DEV_SR=y CONFIG_BLK_DEV_SR_VENDOR=y CONFIG_CHR_DEV_SG=y # # Some SCSI devices (e.g. CD jukebox) support multiple LUNs # # CONFIG_SCSI_MULTI_LUN is not set CONFIG_SCSI_CONSTANTS=y # CONFIG_SCSI_LOGGING is not set # # SCSI low-level drivers # # CONFIG_BLK_DEV_3W_XXXX_RAID is not set # CONFIG_SCSI_7000FASST is not set # CONFIG_SCSI_ACARD is not set # CONFIG_SCSI_AHA152X is not set # CONFIG_SCSI_AHA1542 is not set # CONFIG_SCSI_AHA1740 is not set CONFIG_SCSI_AIC7XXX=m CONFIG_AIC7XXX_TCQ_ON_BY_DEFAULT=y CONFIG_AIC7XXX_CMDS_PER_DEVICE=8 CONFIG_AIC7XXX_PROC_STATS=y # CONFIG_SCSI_IPS is not set # CONFIG_SCSI_ADVANSYS is not set # CONFIG_SCSI_IN2000 is not set # CONFIG_SCSI_AM53C974 is not set # CONFIG_SCSI_MEGARAID is not set # CONFIG_SCSI_BUSLOGIC is not set # CONFIG_SCSI_CPQFCTS is not set # CONFIG_SCSI_DTC3280 is not set # CONFIG_SCSI_EATA is not set # CONFIG_SCSI_EATA_DMA is not set # CONFIG_SCSI_EATA_PIO is not set # CONFIG_SCSI_FUTURE_DOMAIN is not set # CONFIG_SCSI_GDTH is not set # CONFIG_SCSI_GENERIC_NCR5380 is not set # CONFIG_SCSI_INITIO is not set # CONFIG_SCSI_INIA100 is not set # CONFIG_SCSI_NCR53C406A is not set # CONFIG_SCSI_SYM53C416 is not set # CONFIG_SCSI_SIM710 is not set # CONFIG_SCSI_NCR53C7xx is not set # CONFIG_SCSI_NCR53C8XX is not set CONFIG_SCSI_SYM53C8XX=m CONFIG_SCSI_NCR53C8XX_DEFAULT_TAGS=8 CONFIG_SCSI_NCR53C8XX_MAX_TAGS=32 CONFIG_SCSI_NCR53C8XX_SYNC=20 # CONFIG_SCSI_NCR53C8XX_IOMAPPED is not set # CONFIG_SCSI_NCR53C8XX_PQS_PDS is not set # CONFIG_SCSI_NCR53C8XX_SYMBIOS_COMPAT is not set # CONFIG_SCSI_PAS16 is not set # CONFIG_SCSI_PCI2000 is not set # CONFIG_SCSI_PCI2220I is not set # CONFIG_SCSI_PSI240I is not set # CONFIG_SCSI_QLOGIC_FAS is not set # CONFIG_SCSI_QLOGIC_ISP is not set # CONFIG_SCSI_QLOGIC_FC is not set # CONFIG_SCSI_SEAGATE is not set # CONFIG_SCSI_DC390T is not set # CONFIG_SCSI_T128 is not set # CONFIG_SCSI_U14_34F is not set # CONFIG_SCSI_ULTRASTOR is not set # CONFIG_SCSI_DEBUG is not set CONFIG_SCSI_MESH=y CONFIG_SCSI_MESH_SYNC_RATE=5 CONFIG_SCSI_MAC53C94=y # # Network device support # CONFIG_NETDEVICES=y # # ARCnet devices # # CONFIG_ARCNET is not set # CONFIG_DUMMY is not set # CONFIG_BONDING is not set # CONFIG_EQUALIZER is not set CONFIG_ETHERTAP=m # CONFIG_NET_SB1000 is not set # # Ethernet (10 or 100Mbit) # CONFIG_NET_ETHERNET=y CONFIG_MACE=m # CONFIG_MACE_AAUI_PORT is not set # CONFIG_BMAC is not set # CONFIG_GMAC is not set # CONFIG_NCR885E is not set # CONFIG_NET_VENDOR_3COM is not set # CONFIG_LANCE is not set # CONFIG_NET_VENDOR_SMC is not set # CONFIG_NET_VENDOR_RACAL is not set # CONFIG_RTL8139 is not set # CONFIG_RTL8139TOO is not set # CONFIG_NET_ISA is not set # CONFIG_NET_EISA is not set # CONFIG_NET_POCKET is not set # # Ethernet (1000 Mbit) # # CONFIG_ACENIC is not set # CONFIG_HAMACHI is not set # CONFIG_YELLOWFIN is not set # CONFIG_SK98LIN is not set # CONFIG_FDDI is not set # CONFIG_HIPPI is not set # # Appletalk devices # # CONFIG_LTPC is not set # CONFIG_COPS is not set # CONFIG_IPDDP is not set # CONFIG_PPP is not set # CONFIG_SLIP is not set # CONFIG_NET_RADIO is not set # # Token ring devices # # CONFIG_TR is not set # CONFIG_NET_FC is not set # CONFIG_RCPCI is not set # CONFIG_SHAPER is not set # # Wan interfaces # # CONFIG_HOSTESS_SV11 is not set # CONFIG_COSA is not set # CONFIG_SEALEVEL_4021 is not set # CONFIG_SYNCLINK_SYNCPPP is not set # CONFIG_LANMEDIA is not set # CONFIG_COMX is not set # CONFIG_HDLC is not set # CONFIG_DLCI is not set # CONFIG_XPEED is not set # CONFIG_SBNI is not set # # Amateur Radio support # # CONFIG_HAMRADIO is not set # # IrDA (infrared) support # # CONFIG_IRDA is not set # # ISDN subsystem # # CONFIG_ISDN is not set # # Old CD-ROM drivers (not SCSI, not IDE) # # CONFIG_CD_NO_IDESCSI is not set # # Console drivers # CONFIG_DUMMY_CONSOLE=y # CONFIG_FB_PM2 is not set CONFIG_FB_ATY=y CONFIG_FB_OF=y CONFIG_FB_CONTROL=y CONFIG_FB_PLATINUM=y CONFIG_FB_VALKYRIE=y # CONFIG_FB_IMSTT is not set # CONFIG_FB_CT65550 is not set # CONFIG_FB_S3TRIO is not set # CONFIG_FB_COMPAT_XPMAC is not set # CONFIG_FB_MATROX is not set # CONFIG_FB_ATY128 is not set # CONFIG_FB_VIRTUAL is not set # CONFIG_FBCON_ADVANCED is not set CONFIG_FBCON_CFB8=y CONFIG_FBCON_CFB16=y CONFIG_FBCON_CFB24=y CONFIG_FBCON_CFB32=y # CONFIG_FBCON_FONTWIDTH8_ONLY is not set CONFIG_FBCON_FONTS=y # CONFIG_FONT_8x8 is not set CONFIG_FONT_8x16=y CONFIG_FONT_SUN8x16=y CONFIG_FONT_SUN12x22=y # CONFIG_FONT_6x11 is not set # CONFIG_FONT_PEARL_8x8 is not set # CONFIG_FONT_ACORN_8x8 is not set # # Character devices # CONFIG_VT=y CONFIG_VT_CONSOLE=y # CONFIG_SERIAL is not set # CONFIG_SERIAL_EXTENDED is not set # CONFIG_SERIAL_NONSTANDARD is not set CONFIG_UNIX98_PTYS=y CONFIG_UNIX98_PTY_COUNT=256 # CONFIG_MOUSE is not set # # Joysticks # # CONFIG_JOYSTICK is not set # CONFIG_QIC02_TAPE is not set # CONFIG_WATCHDOG is not set CONFIG_NVRAM=y # CONFIG_RTC is not set # CONFIG_INTEL_RNG is not set # CONFIG_AGP is not set # CONFIG_DRM is not set # # Video For Linux # # CONFIG_VIDEO_DEV is not set # CONFIG_DTLK is not set # # Ftape, the floppy tape device driver # # CONFIG_FTAPE is not set # # USB support # # CONFIG_USB is not set # # Mac device drivers # CONFIG_MAC_KEYBOARD=y CONFIG_ADBMOUSE=y CONFIG_PPC_RTC=y CONFIG_MAC_FLOPPY=y CONFIG_MAC_SERIAL=y CONFIG_SERIAL_CONSOLE=y # # Sound # CONFIG_SOUND=m CONFIG_DMASOUND=m # CONFIG_SOUND_CMPCI is not set # CONFIG_SOUND_CS4281 is not set # CONFIG_SOUND_FUSION is not set # CONFIG_SOUND_EMU10K1 is not set # CONFIG_SOUND_ES1370 is not set # CONFIG_SOUND_ES1371 is not set # CONFIG_SOUND_MAESTRO is not set # CONFIG_SOUND_MAESTRO3 is not set # CONFIG_SOUND_ESSSOLO1 is not set # CONFIG_SOUND_ICH is not set # CONFIG_SOUND_SONICVIBES is not set # CONFIG_SOUND_TRIDENT is not set # CONFIG_SOUND_MSNDCLAS is not set # CONFIG_SOUND_MSNDPIN is not set # CONFIG_SOUND_VIA82CXXX is not set # CONFIG_SOUND_OSS is not set # # Filesystems # # CONFIG_QUOTA is not set CONFIG_AUTOFS_FS=m # CONFIG_ADFS_FS is not set # CONFIG_AFFS_FS is not set CONFIG_HFS_FS=m CONFIG_FAT_FS=m # CONFIG_MSDOS_FS is not set # CONFIG_UMSDOS_FS is not set CONFIG_VFAT_FS=m CONFIG_ISO9660_FS=m CONFIG_JOLIET=y # CONFIG_MINIX_FS is not set # CONFIG_NTFS_FS is not set # CONFIG_HPFS_FS is not set CONFIG_PROC_FS=y CONFIG_DEVPTS_FS=y # CONFIG_QNX4FS_FS is not set # CONFIG_ROMFS_FS is not set CONFIG_EXT2_FS=y # CONFIG_SYSV_FS is not set # CONFIG_UFS_FS is not set # CONFIG_EFS_FS is not set # # Network File Systems # # CONFIG_CODA_FS is not set CONFIG_NFS_FS=m # CONFIG_NFS_V3 is not set # CONFIG_NFSD is not set CONFIG_SUNRPC=m CONFIG_LOCKD=m CONFIG_SMB_FS=m CONFIG_SMB_NLS_DEFAULT=y CONFIG_SMB_NLS_REMOTE="cp437" # CONFIG_NCP_FS is not set # # Partition Types # # CONFIG_BSD_DISKLABEL is not set CONFIG_MAC_PARTITION=y # CONFIG_MINIX_SUBPARTITION is not set # CONFIG_SMD_DISKLABEL is not set # CONFIG_SOLARIS_X86_PARTITION is not set # CONFIG_UNIXWARE_DISKLABEL is not set CONFIG_NLS=y # # Native Language Support # CONFIG_NLS_DEFAULT="cp437" CONFIG_NLS_CODEPAGE_437=y # CONFIG_NLS_CODEPAGE_737 is not set # CONFIG_NLS_CODEPAGE_775 is not set # CONFIG_NLS_CODEPAGE_850 is not set # CONFIG_NLS_CODEPAGE_852 is not set # CONFIG_NLS_CODEPAGE_855 is not set # CONFIG_NLS_CODEPAGE_857 is not set # CONFIG_NLS_CODEPAGE_860 is not set # CONFIG_NLS_CODEPAGE_861 is not set # CONFIG_NLS_CODEPAGE_862 is not set # CONFIG_NLS_CODEPAGE_863 is not set # CONFIG_NLS_CODEPAGE_864 is not set # CONFIG_NLS_CODEPAGE_865 is not set # CONFIG_NLS_CODEPAGE_866 is not set # CONFIG_NLS_CODEPAGE_869 is not set # CONFIG_NLS_CODEPAGE_874 is not set # CONFIG_NLS_CODEPAGE_932 is not set # CONFIG_NLS_CODEPAGE_936 is not set # CONFIG_NLS_CODEPAGE_949 is not set # CONFIG_NLS_CODEPAGE_950 is not set # CONFIG_NLS_ISO8859_1 is not set # CONFIG_NLS_ISO8859_2 is not set # CONFIG_NLS_ISO8859_3 is not set # CONFIG_NLS_ISO8859_4 is not set # CONFIG_NLS_ISO8859_5 is not set # CONFIG_NLS_ISO8859_6 is not set # CONFIG_NLS_ISO8859_7 is not set # CONFIG_NLS_ISO8859_8 is not set # CONFIG_NLS_ISO8859_9 is not set # CONFIG_NLS_ISO8859_14 is not set CONFIG_NLS_ISO8859_15=y # CONFIG_NLS_KOI8_R is not set # CONFIG_NLS_KOI8_RU is not set # # Kernel hacking # CONFIG_MAGIC_SYSRQ=y # CONFIG_KGDB is not set # CONFIG_XMON is not set ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Compile failure: 2.2.19 + eide patch on PPC 2001-08-07 19:24 Compile failure: 2.2.19 + eide patch on PPC Mike Fedyk @ 2001-08-07 19:43 ` Phil Brutsche 2001-08-07 21:48 ` Mike Fedyk 2001-08-09 18:32 ` Mike Fedyk 0 siblings, 2 replies; 4+ messages in thread From: Phil Brutsche @ 2001-08-07 19:43 UTC (permalink / raw) To: Mike Fedyk; +Cc: linux-kernel@vger.kernel.org A long time ago, in a galaxy far, far way, someone said... > I am trying to compile 2.2.19 + ide.2.2.19.05042001.patch. When doing this, > I get the errors below. > > I've also tried: > ide.2.2.19.03252001.patch > ide.2.2.19.04092001.patch These patches are broken for PPC machines and have been for some time. I suppose I should file a bug report... It's simple enough to fix however. > I've tried compiling on several different machines, though they were all > setup with Debian 2.2. > > I haven't tried a 2.4.x on ppc, Be aware that 2.4.x on non-x86 architectures is still somewhat experimental (much more so than on x86). > but I want to try to get 2.2 working. Is there another patch I need? Yes - see below > # gcc -v > Reading specs from /usr/lib/gcc-lib/powerpc-linux/2.95.2/specs > gcc version 2.95.2 20000220 (Debian GNU/Linux) > > Error: > make[3]: Entering directory /usr/src/lk2.2/2.2.19-ide-05042001/drivers/block' > cc -D__KERNEL__ -I/usr/src/lk2.2/2.2.19-ide-05042001/include -Wall > -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing > -D__powerpc__ -fsigned-char -msoft-float -pipe -fno-builtin -ffixed-r2 > -Wno-uninitialized -mmultiple -mstring -DEXPORT_SYMTAB -c ll_rw_blk.c > In file included from ll_rw_blk.c:28: > /usr/src/lk2.2/2.2.19-ide-05042001/include/asm/ide.h:53: parse error before *' > /usr/src/lk2.2/2.2.19-ide-05042001/include/asm/ide.h:56: warning: function > declaration isn't a prototype You need an #include <linux/ide.h> before the #include <asm/ide.h> in ll_rw_blk.c. Lines 27-30 of ll_rw_blk.c would end up looking like this: #ifdef CONFIG_POWERMAC #include <linux/ide.h> #include <asm/ide.h> #endif There are a number of other compilation problems in the code that will need similar "fixes". Note that you will need the PCI fixup patch from http://www.cpu.lu/~mlan/linux/dev/pci.html if you want to be able to use a PCI IDE controller card, like the Promise Ultra33/Ultra66/Ultra100, in your PowerMac. It seems that the PCI resources won't get seupt correctly by OpenFirmware otherwise. Phil ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Compile failure: 2.2.19 + eide patch on PPC 2001-08-07 19:43 ` Phil Brutsche @ 2001-08-07 21:48 ` Mike Fedyk 2001-08-09 18:32 ` Mike Fedyk 1 sibling, 0 replies; 4+ messages in thread From: Mike Fedyk @ 2001-08-07 21:48 UTC (permalink / raw) To: linux-kernel@vger.kernel.org On Tue, Aug 07, 2001 at 02:43:53PM -0500, Phil Brutsche wrote: > A long time ago, in a galaxy far, far way, someone said... > > I am trying to compile 2.2.19 + ide.2.2.19.05042001.patch. When doing this, > > I get the errors below. > These patches are broken for PPC machines and have been for some time. I > suppose I should file a bug report... > > It's simple enough to fix however. > > > but I want to try to get 2.2 working. Is there another patch I need? > > Yes - see below > > > # gcc -v > > Reading specs from /usr/lib/gcc-lib/powerpc-linux/2.95.2/specs > > gcc version 2.95.2 20000220 (Debian GNU/Linux) > > > > Error: > > make[3]: Entering directory /usr/src/lk2.2/2.2.19-ide-05042001/drivers/block' > > cc -D__KERNEL__ -I/usr/src/lk2.2/2.2.19-ide-05042001/include -Wall > > -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing > > -D__powerpc__ -fsigned-char -msoft-float -pipe -fno-builtin -ffixed-r2 > > -Wno-uninitialized -mmultiple -mstring -DEXPORT_SYMTAB -c ll_rw_blk.c > > In file included from ll_rw_blk.c:28: > > /usr/src/lk2.2/2.2.19-ide-05042001/include/asm/ide.h:53: parse error before *' > > /usr/src/lk2.2/2.2.19-ide-05042001/include/asm/ide.h:56: warning: function > > declaration isn't a prototype > > You need an > > #include <linux/ide.h> > > before the > > #include <asm/ide.h> > > in ll_rw_blk.c. > > Lines 27-30 of ll_rw_blk.c would end up looking like this: > > #ifdef CONFIG_POWERMAC > #include <linux/ide.h> > #include <asm/ide.h> > #endif > I'm still getting errors in 2.2.19-ide-05042001/include/asm/ide.h line 53 and 56. > There are a number of other compilation problems in the code that will > need similar "fixes". > What more changes do I need to make? > Note that you will need the PCI fixup patch from > http://www.cpu.lu/~mlan/linux/dev/pci.html if you want to be able to use a > PCI IDE controller card, like the Promise Ultra33/Ultra66/Ultra100, in > your PowerMac. It seems that the PCI resources won't get seupt correctly > by OpenFirmware otherwise. Ok, patched, and above changes are applied. I'm including a diff of include/asm/ide.h before and after patching. I still get the errors: In file included from ll_rw_blk.c:28: /usr/src/lk2.2/2.2.19-ide-05042001/include/asm/ide.h:53: parse error before *' /usr/src/lk2.2/2.2.19-ide-05042001/include/asm/ide.h:56: warning: function declaration isn't a prototype diff: --- 2.2.19/include/asm/ide.h Tue Aug 7 10:11:56 2001 +++ 2.2.19-ide-05042001/include/asm/ide.h Tue Aug 7 13:45:17 2001 @@ -18,7 +18,7 @@ #define MAX_HWIFS 4 #endif -typedef unsigned int ide_ioreg_t; +#include <asm/hdreg.h> #ifdef __KERNEL__ @@ -50,16 +50,18 @@ void (*release_region)(ide_ioreg_t from, unsigned int extent); void (*fix_driveid)(struct hd_driveid *id); - void (*ide_init_hwif)(ide_ioreg_t *p, - ide_ioreg_t base, - int *irq); + void (*ide_init_hwif)(hw_regs_t *hw, + ide_ioreg_t data_port, + ide_ioreg_t ctrl_port, + int *irq); int io_base; }; extern struct ide_machdep_calls ppc_ide_md; -void ide_init_hwif_ports(ide_ioreg_t *p, ide_ioreg_t base, int *irq); +void ide_init_hwif_ports (hw_regs_t *hw, ide_ioreg_t data_port, ide_ioreg_t ctrl_port, int *irq); + void ide_insw(ide_ioreg_t port, void *buf, int ns); void ide_outsw(ide_ioreg_t port, void *buf, int ns); void ppc_generic_ide_fix_driveid(struct hd_driveid *id); @@ -81,6 +83,20 @@ return ppc_ide_md.default_io_base(index); } +static __inline__ void ide_init_default_hwifs(void) +{ +#ifndef CONFIG_BLK_DEV_IDEPCI + hw_regs_t hw; + int index; + + for(index = 0; index < MAX_HWIFS; index++) { + ide_init_hwif_ports(&hw, ide_default_io_base(index), 0, NULL); + hw.irq = ide_default_irq(ide_default_io_base(index)); + ide_register_hw(&hw, NULL); + } +#endif /* CONFIG_BLK_DEV_IDEPCI */ +} + static __inline__ int ide_check_region (ide_ioreg_t from, unsigned int extent) { return ppc_ide_md.check_region(from, extent); @@ -96,7 +112,8 @@ ppc_ide_md.release_region(from, extent); } -static __inline__ void ide_fix_driveid (struct hd_driveid *id) { +static __inline__ void ide_fix_driveid (struct hd_driveid *id) +{ ppc_ide_md.fix_driveid(id); } @@ -124,21 +141,13 @@ } b; } select_t; -static __inline__ int ide_request_irq(unsigned int irq, void (*handler)(int, void *, struct pt_regs *), - unsigned long flags, const char *device, void *dev_id) -{ - return request_irq(irq, handler, flags, device, dev_id); -} - -static __inline__ void ide_free_irq(unsigned int irq, void *dev_id) -{ - free_irq(irq, dev_id); -} +#define ide_request_irq(irq,hand,flg,dev,id) request_irq((irq),(hand),(flg),(dev),(id)) +#define ide_free_irq(irq,dev_id) free_irq((irq), (dev_id)) /* * The following are not needed for the non-m68k ports */ -#define ide_ack_intr(base, irq) (1) +#define ide_ack_intr(hwif) (1) #define ide_release_lock(lock) do {} while (0) #define ide_get_lock(lock, hdlr, data) do {} while (0) ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Compile failure: 2.2.19 + eide patch on PPC 2001-08-07 19:43 ` Phil Brutsche 2001-08-07 21:48 ` Mike Fedyk @ 2001-08-09 18:32 ` Mike Fedyk 1 sibling, 0 replies; 4+ messages in thread From: Mike Fedyk @ 2001-08-09 18:32 UTC (permalink / raw) To: Phil Brutsche; +Cc: linux-kernel@vger.kernel.org On Tue, Aug 07, 2001 at 02:43:53PM -0500, Phil Brutsche wrote: > A long time ago, in a galaxy far, far way, someone said... > > > I am trying to compile 2.2.19 + ide.2.2.19.05042001.patch. When doing this, > > I get the errors below. > > > > I've also tried: > > ide.2.2.19.03252001.patch > > ide.2.2.19.04092001.patch > > These patches are broken for PPC machines and have been for some time. I > suppose I should file a bug report... > > It's simple enough to fix however. > > You need an > > #include <linux/ide.h> > > before the > > #include <asm/ide.h> > > in ll_rw_blk.c. > > Lines 27-30 of ll_rw_blk.c would end up looking like this: > > #ifdef CONFIG_POWERMAC > #include <linux/ide.h> > #include <asm/ide.h> > #endif > Ok, I've applied this, and also saved the changes in diff -u format: --- 2.2.19-ide-05042001/drivers/block/ll_rw_blk.c~ Tue Aug 7 15:34:29 2001 +++ 2.2.19-ide-05042001/drivers/block/ll_rw_blk.c Tue Aug 7 15:50:08 2001 @@ -25,6 +25,7 @@ #include <linux/blk.h> #ifdef CONFIG_POWERMAC +#include <linux/ide.h> #include <asm/ide.h> #endif > Note that you will need the PCI fixup patch from > http://www.cpu.lu/~mlan/linux/dev/pci.html if you want to be able to use a > PCI IDE controller card, like the Promise Ultra33/Ultra66/Ultra100, in > your PowerMac. It seems that the PCI resources won't get seupt correctly > by OpenFirmware otherwise. I have three patches applied: ide.2.2.19.05042001.patch.bz2 2.2.18-pci.diff.bz2 (applies with only one hunk shifted, no rejects on 2.2.19) ide-fix.diff (The above diff you described) > There are a number of other compilation problems in the code that will > need similar "fixes". > I still get this same error below: > > # gcc -v > > Reading specs from /usr/lib/gcc-lib/powerpc-linux/2.95.2/specs > > gcc version 2.95.2 20000220 (Debian GNU/Linux) > > > > Error: > > make[3]: Entering directory /usr/src/lk2.2/2.2.19-ide-05042001/drivers/block' > > cc -D__KERNEL__ -I/usr/src/lk2.2/2.2.19-ide-05042001/include -Wall > > -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing > > -D__powerpc__ -fsigned-char -msoft-float -pipe -fno-builtin -ffixed-r2 > > -Wno-uninitialized -mmultiple -mstring -DEXPORT_SYMTAB -c ll_rw_blk.c > > In file included from ll_rw_blk.c:28: > > /usr/src/lk2.2/2.2.19-ide-05042001/include/asm/ide.h:53: parse error before *' > > /usr/src/lk2.2/2.2.19-ide-05042001/include/asm/ide.h:56: warning: function > > declaration isn't a prototype > Is LKML the best place for this question, or should I look for a PPC specific list? If so, can someone point me in the right direction? Mike ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2001-08-09 18:33 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2001-08-07 19:24 Compile failure: 2.2.19 + eide patch on PPC Mike Fedyk 2001-08-07 19:43 ` Phil Brutsche 2001-08-07 21:48 ` Mike Fedyk 2001-08-09 18:32 ` Mike Fedyk
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox