Re: Hang problem on Tyan K7 Thunder resolved -- SB Live! heads-up

Manuel McLure
2001-08-12T23:16:08Z

On 2001.08.12 15:59 Linus Torvalds wrote:

> Mind trying an alternate approach: remove the "if (!woinst)" thing, and
> instead move the line that initializes the tasklets down two lines
> (there's two places, they look something like
>
> tasklet_init(&wiinst->timer.tasklet, emu10k1_wavein_bh,
> (unsigned long) wave_dev);
> wave_dev->wiinst = wiinst;
> emu10k1_wavein_setformat(wave_dev, &wiinst->format);
>
> and they _should_ do the "tasklet_init()" _after_ the other
> initializations, ie move that line down a bit, like so:
>
> wave_dev->wiinst = wiinst;
> emu10k1_wavein_setformat(wave_dev, &wiinst->format);
> tasklet_init(&wiinst->timer.tasklet, emu10k1_wavein_bh,
> (unsigned long) wave_dev);
>
> Does that also fix it?
>
> And sure, I realize that you want to run it for a while..

Done - I'll post any Oops that might show up. No news will good news :-)

--
Manuel A. McLure KE6TAW | ...for in Ulthar, according to an ancient
<manuel@mclure.org> | and significant law, no man may kill a cat.
<http://www.mclure.org> | -- H.P. Lovecraft