From: "David S. Miller" <davem@redhat.com>
To: herbert@gondor.apana.org.au
Cc: linux-kernel@vger.kernel.org
Subject: Re: RFC: poll change
Date: Tue, 14 Aug 2001 15:42:33 -0700 (PDT) [thread overview]
Message-ID: <20010814.154233.98555395.davem@redhat.com> (raw)
In-Reply-To: <E15Wmp0-00056i-00@gondolin.me.apana.org.au>
In-Reply-To: <20010814.144347.95061445.davem@redhat.com> <E15Wmp0-00056i-00@gondolin.me.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Wed, 15 Aug 2001 08:38:02 +1000
Hmm, it still seems to be wrong:
...
if (nfds > current->files->max_fds)
nfds = current->files->max_fds;
The second if statement should be removed. And it might be better to use
current->rlim[RLIMIT_NOFILE].rlim_cur instead of NR_OPEN.
It has to be limited to "max_fds", that is how many files we may
legally address in current->files!
Later,
David S. Miller
davem@redhat.com
next prev parent reply other threads:[~2001-08-14 22:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-14 21:08 RFC: poll change Tim Hockin
2001-08-14 21:43 ` David S. Miller
2001-08-14 22:38 ` Herbert Xu
2001-08-14 22:42 ` David S. Miller [this message]
2001-08-15 0:03 ` Andrea Arcangeli
2001-08-15 0:06 ` David S. Miller
2001-08-15 0:16 ` Andrea Arcangeli
2001-08-15 0:23 ` David S. Miller
2001-08-15 10:40 ` David Schwartz
2001-08-14 22:03 ` RFC: poll change - nevermind Tim Hockin
2001-08-14 22:47 ` Andrea Arcangeli
[not found] <3B79B381.58266C13@sun.com>
[not found] ` <20010814.162710.131914269.davem@redhat.com>
[not found] ` <3B79B5F3.C816CBED@sun.com>
[not found] ` <20010814.163804.66057702.davem@redhat.com>
2001-08-14 23:53 ` RFC: poll change Tim Hockin
2001-08-14 23:53 ` David S. Miller
2001-08-15 0:08 ` Andrea Arcangeli
2001-08-15 0:09 ` Tim Hockin
2001-08-15 0:06 ` David S. Miller
2001-08-15 0:11 ` Andrea Arcangeli
2001-08-15 0:16 ` David S. Miller
2001-08-15 0:30 ` Andrea Arcangeli
2001-08-15 14:13 ` Andrea Arcangeli
2001-08-15 14:24 ` David S. Miller
2001-08-15 14:32 ` Andrea Arcangeli
2001-08-15 16:30 ` Hugh Dickins
2001-08-15 16:40 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010814.154233.98555395.davem@redhat.com \
--to=davem@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox