public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrea Arcangeli <andrea@suse.de>
To: Andrew Morton <akpm@zip.com.au>
Cc: Mark Hemment <markhe@veritas.com>,
	Juergen Doelle <JDOELLE@de.ibm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Align VM locks
Date: Fri, 17 Aug 2001 01:33:56 +0200	[thread overview]
Message-ID: <20010817013356.E8726@athlon.random> (raw)
In-Reply-To: <Pine.LNX.4.33.0108161839180.3340-100000@alloc.wat.veritas.com>, <Pine.LNX.4.33.0108161839180.3340-100000@alloc.wat.veritas.com>; <20010816202606.B8726@athlon.random> <3B7C1B8F.708CBB9@zip.com.au>
In-Reply-To: <3B7C1B8F.708CBB9@zip.com.au>; from akpm@zip.com.au on Thu, Aug 16, 2001 at 12:14:23PM -0700

On Thu, Aug 16, 2001 at 12:14:23PM -0700, Andrew Morton wrote:
> Problem with this approach is that it doesn't prevent the linker
> from placing other data in the same cacheline as the aligned
> lock, at higher addresses.

that was partly intentional, but ok we can be more aggressive on that
side ;).

> Juergen, I'd suggest you dust off that patch, add the conditionals
> which make it a no-op on uniprocessor and submit it.  It's such a

agreed, btw it is just a noop on up but it is undefined for __GNUC__ >
2, also it would be nice if he could do it in linux/ instead of asm/, it
should not need special arch trick (spinlock_t and SMP_CACHE_SIZE are
the only thing it needs).

Andrea

      reply	other threads:[~2001-08-16 23:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-08-16 17:41 [PATCH] Align VM locks Mark Hemment
2001-08-16 18:26 ` Andrea Arcangeli
2001-08-16 18:44   ` Mark Hemment
2001-08-16 18:52     ` Andrea Arcangeli
2001-08-16 18:57       ` Andrea Arcangeli
2001-08-16 19:46       ` Mark Hemment
2001-08-16 20:27         ` Ben LaHaise
2001-08-16 23:35           ` Andrea Arcangeli
2001-08-16 19:14   ` Andrew Morton
2001-08-16 23:33     ` Andrea Arcangeli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010817013356.E8726@athlon.random \
    --to=andrea@suse.de \
    --cc=JDOELLE@de.ibm.com \
    --cc=akpm@zip.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markhe@veritas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox