UMSDOS problems in 2.4.9?

UMSDOS problems in 2.4.9?

[Peter Fales]

My UMSDOS file system stopped working when I switch from 2.4.8 to 
2.4.9.  I can mount the partition as "msdos" or even "vfat" but if
I use "umsdos" there are no files visible.  Has anyone else seen this?

--
Peter Fales			  Lucent Technologies, Room 5B-408
N9IYJ            		  2000 N Naperville Rd PO Box 3033
				  Naperville, IL 60566-7033
internet: psfales@lucent.com  	  work:	(630) 979-8031

Re: UMSDOS problems in 2.4.9?

[OGAWA Hirofumi]

Hi,

Peter Fales <psfales@lucent.com> writes:

> My UMSDOS file system stopped working when I switch from 2.4.8 to 
> 2.4.9.  I can mount the partition as "msdos" or even "vfat" but if
> I use "umsdos" there are no files visible.  Has anyone else seen this?

Probably I think it related to change of filldir_t.
This problem fixed with the following patch?
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

diff -urN linux-2.4.9/fs/umsdos/dir.c umsdos_off_t-2.4.9/fs/umsdos/dir.c
--- linux-2.4.9/fs/umsdos/dir.c	Sat Feb 10 04:29:44 2001
+++ umsdos_off_t-2.4.9/fs/umsdos/dir.c	Sun Aug 19 16:13:25 2001
@@ -67,7 +67,7 @@
 static int umsdos_dir_once (	void *buf,
 				const char *name,
 				int len,
-				off_t offset,
+				loff_t offset,
 				ino_t ino,
 				unsigned type)
 {
diff -urN linux-2.4.9/fs/umsdos/ioctl.c umsdos_off_t-2.4.9/fs/umsdos/ioctl.c
--- linux-2.4.9/fs/umsdos/ioctl.c	Thu Apr 19 03:49:13 2001
+++ umsdos_off_t-2.4.9/fs/umsdos/ioctl.c	Sun Aug 19 16:16:36 2001
@@ -28,7 +28,7 @@
 				     void *buf,
 				     const char *name,
 				     int name_len,
-				     off_t offset,
+				     loff_t offset,
 				     ino_t ino,
 				     unsigned type)
 {
diff -urN linux-2.4.9/fs/umsdos/rdir.c umsdos_off_t-2.4.9/fs/umsdos/rdir.c
--- linux-2.4.9/fs/umsdos/rdir.c	Sat Feb 10 04:29:44 2001
+++ umsdos_off_t-2.4.9/fs/umsdos/rdir.c	Sun Aug 19 16:16:34 2001
@@ -32,7 +32,7 @@
 static int rdir_filldir (	void *buf,
 				const char *name,
 				int name_len,
-				off_t offset,
+				loff_t offset,
 				ino_t ino,
 				unsigned int d_type)
 {

Re: UMSDOS problems in 2.4.9?

[Peter Fales]

Yes.  It works!  Thanks!  Will that change go into the official kernel??
-- 
Peter Fales			  Lucent Technologies, Room 5B-408
N9IYJ            		  2000 N Naperville Rd PO Box 3033
				  Naperville, IL 60566-7033
internet: psfales@lucent.com  	  work:	(630) 979-8031

On Mon, Aug 20, 2001 at 04:24:08AM +0900, OGAWA Hirofumi wrote:
> Hi,
> 
> Peter Fales <psfales@lucent.com> writes:
> 
> > My UMSDOS file system stopped working when I switch from 2.4.8 to 
> > 2.4.9.  I can mount the partition as "msdos" or even "vfat" but if
> > I use "umsdos" there are no files visible.  Has anyone else seen this?
> 
> Probably I think it related to change of filldir_t.
> This problem fixed with the following patch?
> --
> OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
> 
> diff -urN linux-2.4.9/fs/umsdos/dir.c umsdos_off_t-2.4.9/fs/umsdos/dir.c
> --- linux-2.4.9/fs/umsdos/dir.c	Sat Feb 10 04:29:44 2001
> +++ umsdos_off_t-2.4.9/fs/umsdos/dir.c	Sun Aug 19 16:13:25 2001
> @@ -67,7 +67,7 @@
>  static int umsdos_dir_once (	void *buf,
>  				const char *name,
>  				int len,
> -				off_t offset,
> +				loff_t offset,
>  				ino_t ino,
>  				unsigned type)
>  {
> diff -urN linux-2.4.9/fs/umsdos/ioctl.c umsdos_off_t-2.4.9/fs/umsdos/ioctl.c
> --- linux-2.4.9/fs/umsdos/ioctl.c	Thu Apr 19 03:49:13 2001
> +++ umsdos_off_t-2.4.9/fs/umsdos/ioctl.c	Sun Aug 19 16:16:36 2001
> @@ -28,7 +28,7 @@
>  				     void *buf,
>  				     const char *name,
>  				     int name_len,
> -				     off_t offset,
> +				     loff_t offset,
>  				     ino_t ino,
>  				     unsigned type)
>  {
> diff -urN linux-2.4.9/fs/umsdos/rdir.c umsdos_off_t-2.4.9/fs/umsdos/rdir.c
> --- linux-2.4.9/fs/umsdos/rdir.c	Sat Feb 10 04:29:44 2001
> +++ umsdos_off_t-2.4.9/fs/umsdos/rdir.c	Sun Aug 19 16:16:34 2001
> @@ -32,7 +32,7 @@
>  static int rdir_filldir (	void *buf,
>  				const char *name,
>  				int name_len,
> -				off_t offset,
> +				loff_t offset,
>  				ino_t ino,
>  				unsigned int d_type)
>  {

Re: UMSDOS problems in 2.4.9?

[OGAWA Hirofumi]

Peter Fales <psfales@lucent.com> writes:

> Yes.  It works!  Thanks!  Will that change go into the official kernel??

I will send that patch to Linus. However, I don't know whether that is
applied.
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>