Re: With Daniel Phillips Patch

Justin T. Gibbs
2001-08-23T01:32:58Z

> From: "Justin T. Gibbs" <gibbs@scsiguy.com>
> Date: Wed, 22 Aug 2001 18:55:21 -0600
>
> Then it is poorly named. How about "pci_dma32_t". Or better yet,
> uint32_t. How do the guys writing SBUS drivers like the fact that
> all of this mapping stuff is so PCI centric?
>
>Please actually take a look at a few SBUS drivers before
>you open your big mouth. SBUS drivers use a totally different
>API.

Perhaps its different for SBUS, but its not different for ISA
or EISA. The main point here is that if a single driver has
multiple bus attachements they either "luck out" and can use a
"pci api" to talk to their non-pci devices (the aic7xxx driver talks
EISA/VL/PCI) or they have to have different mapping paths (SBUS/PCI driver).
Do you believe that it is architecturally correct to have a single
api or multiple apis? From your "big mouth" comment above, I assume
the later. From the driver's standpoint, the task is pretty much the
same, with perhaps different contraints on the types of address that
can be supported by the device. The "pci" api already allows you
to express this.

--
Justin