From: "David S. Miller" <davem@redhat.com>
To: kakadu_croc@yahoo.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: brlock_is_locked()?
Date: Wed, 22 Aug 2001 11:47:35 -0700 (PDT) [thread overview]
Message-ID: <20010822.114735.128125464.davem@redhat.com> (raw)
In-Reply-To: <20010822183312.11829.qmail@web10908.mail.yahoo.com>
In-Reply-To: <20010822.112619.62651200.davem@redhat.com> <20010822183312.11829.qmail@web10908.mail.yahoo.com>
From: Brad Chapman <kakadu_croc@yahoo.com>
Date: Wed, 22 Aug 2001 11:33:12 -0700 (PDT)
It almost isn't. The problem starts when a third-party protocol
module grabs BR_NETPROTO_LOCK, unloads itself from the networking stack,
and then tries to call ip6_conntrack_protocol_unregister(). Deadlock.
The problem is that we need TWO locks: the brlock to seal the network stack,
and the conntrack rwlock to delete the protocol struct. Sure, you can
always share the rwlock and leave it at that, but if all you need it for
is to load/unload your protocol functions, then why bother polluting
the symbol tables?
What do you think? Share the rwlock and make everybody who has
the brlock just use the core function?
You are only showing me that there is potential a deficiency in the
netfilter interfaces. You ought to discuss with the netfilter people
a way to make the interfaces work better.
This is exactly what I said needed to be done.
Later,
David S. Miller
davem@redhat.com
next prev parent reply other threads:[~2001-08-22 18:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-22 13:04 brlock_is_locked()? Brad Chapman
2001-08-22 16:33 ` brlock_is_locked()? Ben LaHaise
2001-08-22 18:00 ` brlock_is_locked()? Brad Chapman
2001-08-22 18:03 ` brlock_is_locked()? David S. Miller
2001-08-22 18:17 ` brlock_is_locked()? Brad Chapman
2001-08-22 18:26 ` brlock_is_locked()? David S. Miller
2001-08-22 18:33 ` brlock_is_locked()? Brad Chapman
2001-08-22 18:47 ` David S. Miller [this message]
2001-08-22 18:53 ` brlock_is_locked()? Brad Chapman
2001-08-22 19:00 ` brlock_is_locked()? David S. Miller
2001-08-22 19:08 ` brlock_is_locked()? Brad Chapman
2001-08-24 6:49 ` brlock_is_locked()? Jens Axboe
2001-08-24 14:11 ` brlock_is_locked()? Brad Chapman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010822.114735.128125464.davem@redhat.com \
--to=davem@redhat.com \
--cc=kakadu_croc@yahoo.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox