From: "David S. Miller" <davem@redhat.com>
To: gibbs@scsiguy.com
Cc: groudier@free.fr, axboe@suse.de, skraw@ithnet.com,
phillips@bonn-fries.net, linux-kernel@vger.kernel.org
Subject: Re: With Daniel Phillips Patch
Date: Wed, 22 Aug 2001 18:39:12 -0700 (PDT) [thread overview]
Message-ID: <20010822.183912.61335222.davem@redhat.com> (raw)
In-Reply-To: <200108230132.f7N1WkY22194@aslan.scsiguy.com>
In-Reply-To: <20010822.180858.89278064.davem@redhat.com> <200108230132.f7N1WkY22194@aslan.scsiguy.com>
From: "Justin T. Gibbs" <gibbs@scsiguy.com>
Date: Wed, 22 Aug 2001 19:32:46 -0600
Perhaps its different for SBUS, but its not different for ISA
or EISA.
Right, you pass in a NULL pci_dev pointer. What is the
problem with that?
Do you believe that it is architecturally correct to have a single
api or multiple apis?
I think just plain different entry points are the way to do things,
because function pointers and/or extra conditional execution rots when
it's really not needed.
The "pci" api already allows you to express this.
There will be a "struct device" in 2.5.x and lots of unification.
Frankly, I'd rather not touch the SBUS drivers though.
All the devices are cast in stone, I'm the only person
who maintains or even works on any of the drivers, and
the less I have to change at this point the better.
Later,
David S. Miller
davem@redhat.com
next prev parent reply other threads:[~2001-08-23 1:39 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-20 8:36 aic7xxx errors with 2.4.8-ac7 on 440gx mobo Yusuf Goolamabbas
2001-08-20 8:55 ` Cliff Albert
2001-08-20 10:37 ` Alan Cox
2001-08-20 10:56 ` Yusuf Goolamabbas
2001-08-20 10:56 ` Alan Cox
2001-08-20 11:13 ` Yusuf Goolamabbas
2001-08-20 11:09 ` Alan Cox
2001-08-20 16:43 ` Doug Ledford
2001-08-20 12:46 ` Stefan Fleiter
2001-08-20 15:19 ` Ville Herva
2001-08-20 20:33 ` Justin T. Gibbs
2001-08-20 16:45 ` Doug Ledford
2001-08-20 17:23 ` Stefan Fleiter
2001-08-20 20:28 ` Justin T. Gibbs
2001-08-21 20:24 ` Stefan Fleiter
2001-08-20 16:21 ` Cliff Albert
2001-08-20 17:23 ` Peter T. Breuer
2001-08-20 17:28 ` Cliff Albert
2001-08-20 20:27 ` Justin T. Gibbs
2001-08-20 20:45 ` Cliff Albert
2001-08-20 21:04 ` Cliff Albert
2001-08-20 21:09 ` Cliff Albert
2001-08-20 21:45 ` Justin T. Gibbs
2001-08-20 22:36 ` aic7xxx with 2.4.9 on 7899P Sven Heinicke
2001-08-21 14:42 ` With Daniel Phillips Patch (was: aic7xxx with 2.4.9 on 7899P) Sven Heinicke
2001-08-21 15:08 ` Daniel Phillips
2001-08-21 16:48 ` Sven Heinicke
2001-08-21 17:18 ` Justin T. Gibbs
2001-08-21 22:49 ` Sven Heinicke
2001-08-22 13:06 ` Gérard Roudier
2001-08-21 17:26 ` Daniel Phillips
2001-08-21 17:55 ` Stephan von Krawczynski
2001-08-21 18:33 ` Justin T. Gibbs
2001-08-22 6:46 ` Jens Axboe
2001-08-22 13:24 ` Justin T. Gibbs
2001-08-22 15:05 ` With Daniel Phillips Patch David S. Miller
2001-08-22 18:21 ` Gérard Roudier
2001-08-22 18:32 ` David S. Miller
2001-08-22 18:32 ` Justin T. Gibbs
2001-08-22 18:46 ` David S. Miller
2001-08-22 19:41 ` Justin T. Gibbs
2001-08-22 20:19 ` David S. Miller
2001-08-22 21:07 ` Gérard Roudier
2001-08-22 21:14 ` David S. Miller
2001-08-22 21:14 ` David S. Miller
2001-08-22 21:40 ` Justin T. Gibbs
2001-08-22 23:09 ` David S. Miller
2001-08-23 0:01 ` Justin T. Gibbs
2001-08-23 0:40 ` David S. Miller
2001-08-23 0:55 ` Justin T. Gibbs
2001-08-23 1:03 ` Matthew Jacob
2001-08-23 1:08 ` David S. Miller
2001-08-23 1:32 ` Justin T. Gibbs
2001-08-23 1:39 ` David S. Miller [this message]
2001-08-23 1:49 ` Justin T. Gibbs
2001-08-21 22:44 ` With Daniel Phillips Patch (was: aic7xxx with 2.4.9 on 7899P) Sven Heinicke
2001-08-22 0:58 ` Daniel Phillips
2001-08-22 10:25 ` Marcelo Tosatti
2001-08-22 16:09 ` Sven Heinicke
2001-08-22 15:42 ` Marcelo Tosatti
2001-08-22 20:25 ` Sven Heinicke
2001-08-29 7:30 ` Andrey Nekrasov
2001-09-03 14:58 ` Marcelo Tosatti
2001-08-20 22:55 ` aic7xxx errors with 2.4.8-ac7 on 440gx mobo Cliff Albert
2001-08-21 0:36 ` Justin T. Gibbs
2001-08-21 15:34 ` Gérard Roudier
2001-08-20 21:44 ` Justin T. Gibbs
2001-08-20 21:48 ` Cliff Albert
2001-08-25 7:15 ` Cliff Albert
-- strict thread matches above, loose matches on Subject: below --
2001-08-23 1:06 With Daniel Phillips Patch Van Maren, Kevin
2001-08-23 1:31 ` David S. Miller
2001-08-23 1:40 ` Justin T. Gibbs
2001-08-23 1:45 ` David S. Miller
2001-08-23 2:22 Van Maren, Kevin
2001-08-23 2:26 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010822.183912.61335222.davem@redhat.com \
--to=davem@redhat.com \
--cc=axboe@suse.de \
--cc=gibbs@scsiguy.com \
--cc=groudier@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=phillips@bonn-fries.net \
--cc=skraw@ithnet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox