From: Olaf Hering <olh@suse.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linux Kernel Development <linux-kernel@vger.kernel.org>,
Linux Frame Buffer Device Development
<linux-fbdev-devel@lists.sourceforge.net>,
Hollis Blanchard <hollis@austin.ibm.com>
Subject: Re: scr_*() audit
Date: Fri, 24 Aug 2001 13:06:14 +0200 [thread overview]
Message-ID: <20010824130614.F13094@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.05.10108221846140.6842-100000@callisto.of.borg> <20010823231143.A22014@suse.de>
In-Reply-To: <20010823231143.A22014@suse.de>; from olh@suse.de on Thu, Aug 23, 2001 at 11:11:43PM +0200
On Thu, Aug 23, Olaf Hering wrote:
> On Wed, Aug 22, Geert Uytterhoeven wrote:
>
> > + q++
>
> typo :)
>
> > diff -ur linux-2.4.8-ac9/drivers/video/hgafb.c scr-audit-2.4.8-ac9/drivers/video/hgafb.c
> > --- linux-2.4.8-ac9/drivers/video/hgafb.c Mon May 28 11:07:02 2001
> > +++ scr-audit-2.4.8-ac9/drivers/video/hgafb.c Wed Aug 22 18:48:32 2001
> > @@ -203,7 +203,7 @@
> > fillchar = 0x00;
> > spin_unlock_irqrestore(&hga_reg_lock, flags);
> > if (fillchar != 0xbf)
> > - memset((char *)hga_vram_base, fillchar, hga_vram_len);
> > + isa_memset_io((char *)hga_vram_base, fillchar, hga_vram_len);
> > }
> >
> >
> > @@ -279,7 +279,8 @@
> > char *logo = linux_logo_bw;
> > for (y = 134; y < 134 + 80 ; y++) /* this needs some cleanup */
> > for (x = 0; x < 10 ; x++)
> > - *(dest + (y%4)*8192 + (y>>2)*90 + x + 40) = ~*(logo++);
> > + isa_writeb(~*(logo++),
> > + (dest + (y%4)*8192 + (y>>2)*90 + x + 40));
> > }
--- hgafb.c Thu Aug 23 23:19:58 2001
+++ drivers/video/hgafb.c Fri Aug 24 13:02:57 2001
@@ -203,7 +203,7 @@
fillchar = 0x00;
spin_unlock_irqrestore(&hga_reg_lock, flags);
if (fillchar != 0xbf)
- isa_memset_io((char *)hga_vram_base, fillchar, hga_vram_len);
+ isa_memset_io(hga_vram_base, fillchar, hga_vram_len);
}
@@ -280,7 +280,7 @@
for (y = 134; y < 134 + 80 ; y++) /* this needs some cleanup */
for (x = 0; x < 10 ; x++)
isa_writeb(~*(logo++),
- (dest + (y%4)*8192 + (y>>2)*90 + x + 40));
+ *(dest + (y%4)*8192 + (y>>2)*90 + x + 40));
}
#endif /* MODULE */
Anyone with a hercules card around? Do they still work?
Gruss Olaf
--
$ man clone
BUGS
Main feature not yet implemented...
next prev parent reply other threads:[~2001-08-24 11:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-22 17:06 scr_*() audit Geert Uytterhoeven
2001-08-23 21:11 ` Olaf Hering
2001-08-24 11:06 ` Olaf Hering [this message]
2001-08-26 22:30 ` Hollis Blanchard
2001-08-27 7:02 ` Helge Deller
2001-09-29 22:25 ` Geert Uytterhoeven
2001-09-29 22:27 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010824130614.F13094@suse.de \
--to=olh@suse.de \
--cc=geert@linux-m68k.org \
--cc=hollis@austin.ibm.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox