From: "David S. Miller" <davem@redhat.com>
To: paulus@samba.org
Cc: torvalds@transmeta.com, linux-kernel@vger.kernel.org, davidm@hpl.hp.com
Subject: Re: [PATCH] avoid unnecessary cache flushes
Date: Fri, 31 Aug 2001 15:45:50 -0700 (PDT) [thread overview]
Message-ID: <20010831.154550.70219421.davem@redhat.com> (raw)
In-Reply-To: <15247.29338.3671.548678@cargo.ozlabs.ibm.com>
In-Reply-To: <15247.29338.3671.548678@cargo.ozlabs.ibm.com>
From: Paul Mackerras <paulus@samba.org>
Date: Fri, 31 Aug 2001 21:18:50 +1000 (EST)
Any comments from the architecture maintainers? Linus, does this look
OK to apply to your tree?
No comments other than it will silently break sparc64 as you've
updated the declarations in the asm-sparc64 headers but failed to
fixup the assembler routine itself to expect the page * arg.
I would suggest instead to change the name of the assembler
routine to __copy_user_page et al. and make copy_user_page just
an inline or define which plucks out page->address and passes
that onto __copy_user_page. This way you require no knowledge
of Sparc assembly whatsoever.
Later,
David S. Miller
davem@redhat.com
next prev parent reply other threads:[~2001-08-31 22:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-31 11:18 [PATCH] avoid unnecessary cache flushes Paul Mackerras
2001-08-31 22:45 ` David S. Miller [this message]
2001-09-01 8:35 ` Paul Mackerras
2001-09-01 8:55 ` David S. Miller
2001-09-01 11:47 ` Paul Mackerras
2001-09-01 12:24 ` David S. Miller
2001-09-03 20:14 ` Richard Henderson
2001-09-03 20:27 ` David Mosberger
2001-09-03 20:41 ` Richard Henderson
2001-09-03 21:00 ` David Mosberger
2001-09-04 16:37 ` Richard Henderson
2001-09-04 17:06 ` David Mosberger
2001-09-04 1:53 ` Paul Mackerras
2001-09-04 2:31 ` Andrea Arcangeli
2001-09-04 4:08 ` Paul Mackerras
2001-09-04 12:58 ` Andrea Arcangeli
2001-09-04 16:44 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010831.154550.70219421.davem@redhat.com \
--to=davem@redhat.com \
--cc=davidm@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox