Re: A possible direction for the next LVM driver

Joe Thornber
2001-08-31T09:35:58Z

On Fri, Aug 31, 2001 at 11:20:20AM +0200, Jens Axboe wrote:
> On Thu, Aug 30 2001, Joe Thornber wrote:
> > Hi,
> >
> > I'm working on the next iteration of the LVM driver, specifically
> > trying to address the critism directed at the rather ugly ioctl
> > interface. The code has reached the stage where it works and it's
> > possible to see what I'm aiming for. I would appreciate it if people
> > could spare the time to review this and give me feedback. If there is
> > general agreement that this is moving in the right direction then the
> > next major version of LVM may be based around a future version of this
> > driver. Please CC me in replies. The code can be found at:
> >
> > ftp://ftp.sistina.com/pub/LVM2/device-mapper/device-mapper.tar.bz2
>
> Looks interesting, here's patch to fix possible infinite loop in your
> make_request_fn.

Great, thanks.

> Another quick note -- you might want to consider
> slab'ifying the io_hook allocation/deallocation...

yes, I'd thought of this, hence the comment ...

/* FIXME: These should have their own slab */
inline static struct io_hook *alloc_io_hook(void)

I'll change that now.

- Joe