Re: [PATCH] avoid unnecessary cache flushes

David S. Miller
2001-08-31T22:45:52Z

From: Paul Mackerras <paulus@samba.org>
Date: Fri, 31 Aug 2001 21:18:50 +1000 (EST)

Any comments from the architecture maintainers? Linus, does this look
OK to apply to your tree?

No comments other than it will silently break sparc64 as you've
updated the declarations in the asm-sparc64 headers but failed to
fixup the assembler routine itself to expect the page * arg.

I would suggest instead to change the name of the assembler
routine to __copy_user_page et al. and make copy_user_page just
an inline or define which plucks out page->address and passes
that onto __copy_user_page. This way you require no knowledge
of Sparc assembly whatsoever.

Later,
David S. Miller
davem@redhat.com