* PATCH: linux-2.4.10-pre4/drivers/net/irda/irda-usb.c incorrectly matched to other USB devices
@ 2001-09-05 4:55 Adam J. Richter
2001-09-05 22:46 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Adam J. Richter @ 2001-09-05 4:55 UTC (permalink / raw)
To: dag, linux-kernel, torvalds; +Cc: bhards, bvermeul
[-- Attachment #1: Type: text/plain, Size: 957 bytes --]
linux-2.4.10-pre4/drivers/net/irda/irda-usb.c was missing a
match flag in its array of usb_device_id's, causing it to claim
and attempt to talk to at least one completely incompatible device:
the D-Link DWL-120 USB wireless ethernet adapter. The hot plugging
code also uses this information, causing the irda-usb driver to be
helpfully autoloaded so that it can incorrectly claim this device
even if the module was not originally loaded.
I have verified that, with this patch, the irda-usb driver
is no longer incorrectly loaded when a DWL-120 wireless ethernet
adapter is plugged in.
To all the appropriate people: please apply this patch. Thanks
in advance.
--
Adam J. Richter __ ______________ 4880 Stevens Creek Blvd, Suite 104
adam@yggdrasil.com \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
fax +1 408 261-6631 "Free Software For The Rest Of Us."
[-- Attachment #2: irda.diff --]
[-- Type: text/plain, Size: 634 bytes --]
--- linux-2.4.10-pre4/drivers/net/irda/irda-usb.c Sun Aug 5 13:12:40 2001
+++ linux/drivers/net/irda/irda-usb.c Tue Sep 4 21:19:43 2001
@@ -76,7 +76,8 @@
{ USB_DEVICE(0x50f, 0x180), driver_info: IUC_SPEED_BUG | IUC_NO_WINDOW },
/* Extended Systems, Inc., XTNDAccess IrDA USB (ESI-9685) */
{ USB_DEVICE(0x8e9, 0x100), driver_info: IUC_SPEED_BUG | IUC_NO_WINDOW },
- { match_flags: USB_DEVICE_ID_MATCH_INT_CLASS,
+ { match_flags: USB_DEVICE_ID_MATCH_INT_CLASS |
+ USB_DEVICE_ID_MATCH_INT_SUBCLASS,
bInterfaceClass: USB_CLASS_APP_SPEC,
bInterfaceSubClass: USB_CLASS_IRDA,
driver_info: IUC_DEFAULT, },
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: PATCH: linux-2.4.10-pre4/drivers/net/irda/irda-usb.c incorrectly matched to other USB devices
2001-09-05 4:55 PATCH: linux-2.4.10-pre4/drivers/net/irda/irda-usb.c incorrectly matched to other USB devices Adam J. Richter
@ 2001-09-05 22:46 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2001-09-05 22:46 UTC (permalink / raw)
To: Adam J. Richter; +Cc: dag, linux-kernel, torvalds, bhards, bvermeul
On Tue, Sep 04, 2001 at 09:55:53PM -0700, Adam J. Richter wrote:
> --- linux-2.4.10-pre4/drivers/net/irda/irda-usb.c Sun Aug 5 13:12:40 2001
> +++ linux/drivers/net/irda/irda-usb.c Tue Sep 4 21:19:43 2001
> @@ -76,7 +76,8 @@
> { USB_DEVICE(0x50f, 0x180), driver_info: IUC_SPEED_BUG | IUC_NO_WINDOW },
> /* Extended Systems, Inc., XTNDAccess IrDA USB (ESI-9685) */
> { USB_DEVICE(0x8e9, 0x100), driver_info: IUC_SPEED_BUG | IUC_NO_WINDOW },
> - { match_flags: USB_DEVICE_ID_MATCH_INT_CLASS,
> + { match_flags: USB_DEVICE_ID_MATCH_INT_CLASS |
> + USB_DEVICE_ID_MATCH_INT_SUBCLASS,
> bInterfaceClass: USB_CLASS_APP_SPEC,
> bInterfaceSubClass: USB_CLASS_IRDA,
> driver_info: IUC_DEFAULT, },
That should be:
{ USB_INTERFACE_INFO (USB_CLASS_APP_SPEC, USB_CLASS_IRDA, 0), driver_info: IUC_DEFAULT},
according to the IrDA USB spec.
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2001-09-05 22:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-09-05 4:55 PATCH: linux-2.4.10-pre4/drivers/net/irda/irda-usb.c incorrectly matched to other USB devices Adam J. Richter
2001-09-05 22:46 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox