public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrea Arcangeli <andrea@suse.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: David Mosberger <davidm@hpl.hp.com>, linux-kernel@vger.kernel.org
Subject: Re: [patch] proposed fix for ptrace() SMP race
Date: Fri, 7 Sep 2001 15:34:25 +0200	[thread overview]
Message-ID: <20010907153425.P11329@athlon.random> (raw)
In-Reply-To: <20010907032801.N11329@athlon.random> <E15fAdr-0000r7-00@the-village.bc.nu>
In-Reply-To: <E15fAdr-0000r7-00@the-village.bc.nu>; from alan@lxorguk.ukuu.org.uk on Fri, Sep 07, 2001 at 02:41:11AM +0100

On Fri, Sep 07, 2001 at 02:41:11AM +0100, Alan Cox wrote:
> > +#ifdef CONFIG_SMP
> > +	rmb(); /* read child->has_cpu after child->state */
> > +	while (child->has_cpu);
> 		rep_nop();
> 
> otherwise your PIV will overheat

indeed correct (OTOH it's a so small window [not like a contended
spinlock] that I wonder if it will make a difference in real life ;)

Andrea

  reply	other threads:[~2001-09-07 13:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-09-06 23:00 [patch] proposed fix for ptrace() SMP race David Mosberger
2001-09-07  0:19 ` Andrea Arcangeli
2001-09-07  0:40   ` David Mosberger
2001-09-07  1:28     ` Andrea Arcangeli
2001-09-07  1:41       ` Alan Cox
2001-09-07 13:34         ` Andrea Arcangeli [this message]
2001-09-07  5:21       ` David Mosberger
2001-09-07 13:28         ` Andrea Arcangeli
2001-09-07 15:35           ` David Mosberger
2001-09-08 17:11             ` Andrea Arcangeli
2001-09-10 17:20               ` David Mosberger
  -- strict thread matches above, loose matches on Subject: below --
2001-09-10 17:54 Manfred Spraul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20010907153425.P11329@athlon.random \
    --to=andrea@suse.de \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=davidm@hpl.hp.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox