From: andrew may <acmay@acmay.homeip.net>
To: Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Ani Joshi <ajoshi@shell.unixbox.com>
Subject: missing break? linux/drivers/video/riva/fbdev.c
Date: Thu, 13 Sep 2001 21:26:17 -0700 [thread overview]
Message-ID: <20010913212617.A3946@ecam.san.rr.com> (raw)
I have noticed this in the 2.4.10-pre patches.
It looks like an obvious missing break on after rc =15;
diff -u --recursive --new-file v2.4.9/linux/drivers/video/riva/fbdev.c linux/drivers/video/riva/fbdev.c
--- v2.4.9/linux/drivers/video/riva/fbdev.c Wed Jul 25 17:10:24 2001
+++ linux/drivers/video/riva/fbdev.c Fri Sep 7 09:28:38 2001
@@ -260,7 +260,7 @@
#endif
#ifndef MODULE
-static const char *mode_option __initdata = NULL;
+static char *mode_option __initdata = NULL;
#else
static char *font = NULL;
#endif
@@ -1109,6 +1109,8 @@
break;
#endif
#ifdef FBCON_HAS_CFB16
+ case 15:
+ rc = 15; /* fix for 15 bpp depths on Riva 128 based cards */
case 16:
rc = 16; /* directcolor... 16 entries SW palette */
break; /* Mystique: truecolor, 16 entries SW palette, HW palette hardwired into 1:1 mapping */
@@ -1119,7 +1121,6 @@
next reply other threads:[~2001-09-14 4:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-14 4:26 andrew may [this message]
-- strict thread matches above, loose matches on Subject: below --
2001-09-14 18:09 missing break? linux/drivers/video/riva/fbdev.c Petr Vandrovec
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010913212617.A3946@ecam.san.rr.com \
--to=acmay@acmay.homeip.net \
--cc=ajoshi@shell.unixbox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox