From: Jens Axboe <axboe@suse.de>
To: Douglas Gilbert <dougg@torque.net>
Cc: lkml@krimedawg.org, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org
Subject: Re: OOPS in scsi generic stuff 2.4.10-pre6
Date: Mon, 17 Sep 2001 09:59:02 +0200 [thread overview]
Message-ID: <20010917095902.A1717@suse.de> (raw)
In-Reply-To: <3BA4CB70.50B4A3AB@torque.net> <20010916182208.B9006@suse.de> <20010916185522.D9006@suse.de> <3BA5759B.B5743C6D@torque.net>
In-Reply-To: <3BA5759B.B5743C6D@torque.net>
On Mon, Sep 17 2001, Douglas Gilbert wrote:
> Jens Axboe wrote:
> >
> > On Sun, Sep 16 2001, Jens Axboe wrote:
> > > It looks like a race in that sg_cmd_done_bh can be completed before
> > > generic_unplug_device is called (and thus on a free'd scsi request). We
> > > then pass an invalid queue to generic_unplug_device.
> >
> > (corrected version, scsi_allocate_request can of course fail)
>
> Jens,
> Prior to this patch (actually the first one you posted
> today) sg_dd would frequently crash in generic_unplug_device
> when tested against the scsi_debug adapter driver. [I have
> hacked up that driver to simulate a large number of (ram)
> disks to test Richard Gooch's 2000+ scsi disk patch.]
>
> The way scsi_debug handles all its commands, the bottom
> half handler in sg will be called before scsi_do_req()
> completes. With this patch the problem goes away.
Good, so at least that long standing race has been closed now.
--
Jens Axboe
next prev parent reply other threads:[~2001-09-17 7:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-16 15:55 OOPS in scsi generic stuff 2.4.10-pre6 Douglas Gilbert
2001-09-16 16:22 ` Jens Axboe
2001-09-16 16:55 ` Jens Axboe
2001-09-17 4:01 ` Douglas Gilbert
2001-09-17 7:59 ` Jens Axboe [this message]
-- strict thread matches above, loose matches on Subject: below --
2001-09-16 7:57 lkml
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010917095902.A1717@suse.de \
--to=axboe@suse.de \
--cc=dougg@torque.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=lkml@krimedawg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox