From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id ; Wed, 19 Sep 2001 19:40:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id ; Wed, 19 Sep 2001 19:40:10 -0400 Received: from [195.223.140.107] ([195.223.140.107]:36081 "EHLO athlon.random") by vger.kernel.org with ESMTP id ; Wed, 19 Sep 2001 19:39:55 -0400 Date: Thu, 20 Sep 2001 01:40:17 +0200 From: Andrea Arcangeli To: Alexander Viro Cc: Linus Torvalds , Kernel Mailing List Subject: Re: Linux 2.4.10-pre11 Message-ID: <20010920014017.E720@athlon.random> In-Reply-To: <20010920010338.B720@athlon.random> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ; from viro@math.psu.edu on Wed, Sep 19, 2001 at 07:30:55PM -0400 X-GnuPG-Key-URL: http://e-mind.com/~andrea/aa.gnupg.asc X-PGP-Key-URL: http://e-mind.com/~andrea/aa.asc Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 19, 2001 at 07:30:55PM -0400, Alexander Viro wrote: > "swapon() messing with block_size when accidentially called for mounted swap should never change softblocksize etc.. the concept of softblocksize will die as soon as we make the buffercache - physically address space backed. > Umm... Not doing unnecessary work? Semantics of releasing a block device > depends on the kind of use. BTW, I'm less than sure that fsync_dev() is > the right thing for file access now that you've got that in pagecache - > __block_fsync() seems to be more correct thing to do. Not really, blkdev isn't a filesystem. It will never have a superblock and its own inodes and we also need to filemap_fdatasync/wait the physical address space. > /me goes to get some sleep. night. Andrea