From: Mitchell Blank Jr <mitch@sfgoth.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: tip@prs.de,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
laughing@shared-source.org
Subject: Re: [PATCH] 2.4.10-pre13: ATM drivers cause panic
Date: Sun, 23 Sep 2001 02:33:45 -0700 [thread overview]
Message-ID: <20010923023345.C62864@sfgoth.com> (raw)
In-Reply-To: <3BAC93D4.65E17AA6@internetwork-ag.de> <E15kpDk-0003Xu-00@the-village.bc.nu>
In-Reply-To: <E15kpDk-0003Xu-00@the-village.bc.nu>; from alan@lxorguk.ukuu.org.uk on Sat, Sep 22, 2001 at 05:01:36PM +0100
Alan Cox wrote:
> > Anyways, please find a (quick) patch below. It would be great if this patch or
> > any other similar could make it into the next release!
> > Thanks,
>
> That patch cannot possibly be correct. alloc_atm_dev sleeps
Actually there are a LOT of places that atm_dev_lock is held across sleeps -
I've been meaning to deal with them for awhile. Some of them are noted by
the Stanford checker, others are outside its reach (like calls into the
function pointers in atm_dev). I've been meaning to fix it once and for all
by turning that spinlock into a semaphore, but have not had a chance to
audit the code and make sure that it will be safe in all circumstances.
I need to trace all the interrupt paths and see what their locking needs
are.
I'm not at home tonight so I can't look at the code much right now, but
I'll try to sort out what the best fix is and forward it on to you.
-Mitch
next prev parent reply other threads:[~2001-09-23 9:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-21 17:19 [BUG] 2.4.10-pre13: ATM drivers cause panic Till Immanuel Patzschke
2001-09-21 17:25 ` Alan Cox
2001-09-21 17:51 ` Till Immanuel Patzschke
2001-09-22 13:36 ` [PATCH] " Till Immanuel Patzschke
2001-09-22 16:01 ` Alan Cox
2001-09-23 9:33 ` Mitchell Blank Jr [this message]
2001-09-22 16:04 ` Alan Cox
2001-09-24 9:47 ` Till Immanuel Patzschke
2001-09-24 12:16 ` Mr. James W. Laferriere
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010923023345.C62864@sfgoth.com \
--to=mitch@sfgoth.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=laughing@shared-source.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tip@prs.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox