From: "David S. Miller" <davem@redhat.com>
To: taral@taral.net
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bug in ipip.c SIOCDELTUNNEL
Date: Mon, 24 Sep 2001 22:11:19 -0700 (PDT) [thread overview]
Message-ID: <20010924.221119.90368086.davem@redhat.com> (raw)
In-Reply-To: <20010922024241.A620@taral.net>
In-Reply-To: <20010922024241.A620@taral.net>
From: Taral <taral@taral.net>
Date: Sat, 22 Sep 2001 02:42:41 -0500
Patch is attached. Basically we were always removing "tunl0" even if a
different tunnel was specified.
A bug in one tunnel driver is likely to be in all the
others :-) I've taken care of that and the patch I am
using is below:
--- net/ipv4/ipip.c.~1~ Mon Sep 17 17:36:07 2001
+++ net/ipv4/ipip.c Mon Sep 24 22:09:53 2001
@@ -1,7 +1,7 @@
/*
* Linux NET3: IP/IP protocol decoder.
*
- * Version: $Id: ipip.c,v 1.47 2001/09/18 00:36:07 davem Exp $
+ * Version: $Id: ipip.c,v 1.48 2001/09/25 05:09:53 davem Exp $
*
* Authors:
* Sam Lantinga (slouken@cs.ucdavis.edu) 02/01/95
@@ -758,6 +758,7 @@
err = -EPERM;
if (t == &ipip_fb_tunnel)
goto done;
+ dev = t->dev;
}
err = unregister_netdevice(dev);
break;
--- net/ipv4/ip_gre.c.~1~ Wed May 16 22:27:58 2001
+++ net/ipv4/ip_gre.c Mon Sep 24 22:08:43 2001
@@ -1011,6 +1011,7 @@
err = -EPERM;
if (t == &ipgre_fb_tunnel)
goto done;
+ dev = t->dev;
}
err = unregister_netdevice(dev);
break;
--- net/ipv6/sit.c.~1~ Fri Aug 31 17:31:50 2001
+++ net/ipv6/sit.c Mon Sep 24 22:09:53 2001
@@ -6,7 +6,7 @@
* Pedro Roque <roque@di.fc.ul.pt>
* Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>
*
- * $Id: sit.c,v 1.52 2001/09/01 00:31:50 davem Exp $
+ * $Id: sit.c,v 1.53 2001/09/25 05:09:53 davem Exp $
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License
@@ -712,6 +712,7 @@
err = -EPERM;
if (t == &ipip6_fb_tunnel)
goto done;
+ dev = t->dev;
}
err = unregister_netdevice(dev);
break;
prev parent reply other threads:[~2001-09-25 5:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-22 7:42 [PATCH] Bug in ipip.c SIOCDELTUNNEL Taral
2001-09-25 5:11 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010924.221119.90368086.davem@redhat.com \
--to=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=taral@taral.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox