From: Benjamin LaHaise <bcrl@redhat.com>
To: Andrea Arcangeli <andrea@suse.de>, torvalds@transmeta.com
Cc: Rik van Riel <riel@conectiva.com.br>,
Olivier Sessink <olivier@lx.student.wau.nl>,
linux-kernel@vger.kernel.org
Subject: [patch] Re: weird memory related problems, negative memory usage or fake memory usage?
Date: Tue, 25 Sep 2001 20:07:28 -0400 [thread overview]
Message-ID: <20010925200728.A30860@redhat.com> (raw)
In-Reply-To: <20010926003626.L8350@athlon.random> <Pine.LNX.4.33L.0109251952330.26091-100000@duckman.distro.conectiva> <20010926011116.X8350@athlon.random>
In-Reply-To: <20010926011116.X8350@athlon.random>; from andrea@suse.de on Wed, Sep 26, 2001 at 01:11:16AM +0200
On Wed, Sep 26, 2001 at 01:11:16AM +0200, Andrea Arcangeli wrote:
> possibly yes but maybe not, dunno right now or I would be just sending
> the fix inline in this email :). As said I never seen it before Ben's
> tlb shootdown was merged into mainline, but again I repeat it can
> _really_ be just an unlucky coincidence. But I guess because of this
> coincidence the tlb shootdown will be the first things I will audit
> tomorrow.
This should fix it.
-ben
... v2.4.10-rss.diff ...
diff -urN v2.4.10/mm/memory.c foo/mm/memory.c
--- v2.4.10/mm/memory.c Mon Sep 24 02:16:05 2001
+++ foo/mm/memory.c Tue Sep 25 20:03:04 2001
@@ -319,7 +319,9 @@
if (pte_none(pte))
continue;
if (pte_present(pte)) {
- freed ++;
+ struct page *page = pte_page(pte);
+ if (!PageReserved(page) && VALID_PAGE(page))
+ freed ++;
/* This will eventually call __free_pte on the pte. */
tlb_remove_page(tlb, ptep, address + offset);
} else {
next prev parent reply other threads:[~2001-09-26 0:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-24 21:31 weird memory related problems, negative memory usage or fake memory usage? Olivier Sessink
2001-09-24 22:03 ` Rik van Riel
2001-09-25 22:36 ` Andrea Arcangeli
2001-09-25 22:54 ` Rik van Riel
2001-09-25 23:11 ` Andrea Arcangeli
2001-09-26 0:07 ` Benjamin LaHaise [this message]
2001-09-27 13:41 ` [patch] " Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010925200728.A30860@redhat.com \
--to=bcrl@redhat.com \
--cc=andrea@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=olivier@lx.student.wau.nl \
--cc=riel@conectiva.com.br \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox