From: Russell King <rmk@arm.linux.org.uk>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linus Torvalds <torvalds@transmeta.com>,
linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Ben LaHaise <bcrl@redhat.com>, Andrea Arcangeli <andrea@suse.de>
Subject: Re: [patch] softirq performance fixes, cleanups, 2.4.10.
Date: Wed, 26 Sep 2001 19:55:13 +0100 [thread overview]
Message-ID: <20010926195513.A3664@flint.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.33.0109261729570.5644-200000@localhost.localdomain>
In-Reply-To: <Pine.LNX.4.33.0109261729570.5644-200000@localhost.localdomain>; from mingo@elte.hu on Wed, Sep 26, 2001 at 06:44:03PM +0200
On Wed, Sep 26, 2001 at 06:44:03PM +0200, Ingo Molnar wrote:
> - the generic definition of __cpu_raise_softirq() used to override
> any lowlevel definitions done in asm/softirq.h. It's now conditional so
> the architecture definitions should actually be used.
Ingo,
The generic definition is the one to use - we used to allow
__cpu_raise_softirq from outside IRQ context, but all RISC architectures
ended up with code as follows:
restore irqs
save + disable irqs
set bit
restore irqs
In the latest kernels, you will notice that __cpu_raise_softirq is always
within an IRQ protected region (thanks to Andrea for that work), so there
is no reason for it to protected itself from interrupts. Hence the comment
above cpu_raise_softirq:
* This function must run with irq disabled!
--
Russell King (rmk@arm.linux.org.uk) The developer of ARM Linux
http://www.arm.linux.org.uk/personal/aboutme.html
next prev parent reply other threads:[~2001-09-26 18:55 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-26 16:44 [patch] softirq performance fixes, cleanups, 2.4.10 Ingo Molnar
2001-09-26 17:48 ` Mike Kravetz
2001-09-26 18:48 ` Ingo Molnar
2001-09-26 18:55 ` Russell King [this message]
2001-09-26 19:14 ` Ingo Molnar
2001-09-27 23:31 ` Andrea Arcangeli
2001-09-28 3:20 ` Andrea Arcangeli
2001-09-28 7:34 ` Ingo Molnar
2001-09-28 15:17 ` Andrea Arcangeli
2001-09-28 7:18 ` [patch] softirq-2.4.10-B2 Ingo Molnar
2001-09-28 15:58 ` Andrea Arcangeli
2001-09-28 18:36 ` Simon Kirby
2001-09-28 18:47 ` Ingo Molnar
2001-09-28 19:31 ` kuznet
2001-09-28 16:18 ` [patch] softirq performance fixes, cleanups, 2.4.10 kuznet
2001-09-28 16:31 ` Ingo Molnar
2001-09-28 17:04 ` kuznet
2001-09-28 17:21 ` Rik van Riel
2001-09-28 17:31 ` Andrea Arcangeli
2001-09-28 17:41 ` kuznet
2001-09-28 17:46 ` Ingo Molnar
2001-09-28 18:39 ` Josh MacDonald
2001-09-28 17:31 ` Ingo Molnar
2001-09-28 17:56 ` kuznet
2001-09-28 18:28 ` Ingo Molnar
2001-09-28 19:23 ` kuznet
2001-09-28 19:48 ` Ingo Molnar
2001-09-29 16:35 ` kuznet
2001-09-30 9:37 ` Kai Henningsen
2001-09-30 9:01 ` Ingo Molnar
2001-09-28 19:39 ` kuznet
2001-09-28 20:03 ` Ingo Molnar
2001-09-28 18:51 ` Benjamin LaHaise
2001-09-28 16:32 ` Andrea Arcangeli
2001-09-28 16:46 ` Ingo Molnar
2001-09-28 16:58 ` Andrea Arcangeli
2001-09-28 16:35 ` [patch] softirq-2.4.10-B3 Ingo Molnar
2001-09-29 0:40 ` J . A . Magallon
2001-09-29 11:03 ` [patch] softirq performance fixes, cleanups, 2.4.10 Rusty Russell
-- strict thread matches above, loose matches on Subject: below --
2001-09-27 23:29 Oleg Nesterov
2001-09-28 0:03 ` Andrea Arcangeli
2001-09-28 6:57 ` Ingo Molnar
2001-09-28 2:50 Oleg Nesterov
2001-09-28 7:56 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010926195513.A3664@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andrea@suse.de \
--cc=bcrl@redhat.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox