From: Andrea Arcangeli <andrea@suse.de>
To: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: 2.4.10aa1 - 0-order allocation failed.
Date: Wed, 26 Sep 2001 23:58:17 +0200 [thread overview]
Message-ID: <20010926235817.W27945@athlon.random> (raw)
In-Reply-To: <20010926233451.V27945@athlon.random> <Pine.LNX.4.21.0109261722010.957-100000@freak.distro.conectiva>
In-Reply-To: <Pine.LNX.4.21.0109261722010.957-100000@freak.distro.conectiva>; from marcelo@conectiva.com.br on Wed, Sep 26, 2001 at 05:24:28PM -0300
On Wed, Sep 26, 2001 at 05:24:28PM -0300, Marcelo Tosatti wrote:
>
>
> On Wed, 26 Sep 2001, Andrea Arcangeli wrote:
>
>
> <snip>
>
> > > Andrea,
> > >
> > > This is going to make __GFP_NOFS allocations call writepage(): deadlock.
> >
> > (side note: I assume you mean GFP_NOFS)
> >
> > GFP_NOFS will never call writepage with the above change, obviously
> > because __GFP_FS isn't set. So it can't deadlock.
>
> if ((gfp_mask & __GFP_FS) && ((gfp_mask & __GFP_HIGHIO) || !PageHighMem(page)) && writepage) {
^^
>
> ^^ ^^^^^ ^^^^ ^^^^^
>
> If the page is not highmem, we are going to write the page. (independantly
> of any GFP flag)
>
> I'm I over looking something ?
the && on the left of the (((gfp_mask & __GFP_HIGHIO) || !PageHighMem(page)).
Andrea
prev parent reply other threads:[~2001-09-26 21:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-26 14:07 2.4.10aa1 - 0-order allocation failed Oleg A. Yurlov
2001-09-26 14:45 ` Andrea Arcangeli
2001-09-26 15:02 ` Marcelo Tosatti
2001-09-26 16:31 ` Andrea Arcangeli
2001-09-26 18:49 ` Marcelo Tosatti
2001-09-26 21:34 ` Andrea Arcangeli
2001-09-26 20:24 ` Marcelo Tosatti
2001-09-26 21:58 ` Andrea Arcangeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010926235817.W27945@athlon.random \
--to=andrea@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox