public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] nfsd 2.4.10: unbloat filehandles for export points
@ 2001-10-02 23:03 Chip Salzenberg
  0 siblings, 0 replies; only message in thread
From: Chip Salzenberg @ 2001-10-02 23:03 UTC (permalink / raw)
  To: Linux Kernel; +Cc: Trond Myklebust, David Mazieres

The otherwise excellent nfsd patches in 2.4.10 accidentally inflated
all filehandles for export points to the max size permitted by NFSv3:
64 bytes.  This problem isn't just cosmetic; it also breaks SFS
(http://sfs.fs.net).  Granted, SFS isn't living quite within the law,
but still there's no reason to inflate filehandles.

Thus, this (tested) patch:

--- linux_o/fs/nfsd/nfsfh.c.old	Thu Sep 20 21:02:01 2001
+++ linux/fs/nfsd/nfsfh.c	Tue Oct  2 15:46:47 2001
@@ -732,6 +732,8 @@
 	struct super_block *sb = dentry->d_inode->i_sb;
 	
-	if (dentry == exp->ex_dentry)
+	if (dentry == exp->ex_dentry) {
+		*maxsize = 0;
 		return 0;
+	}
 
 	if (sb->s_op->dentry_to_fh) {

-- 
Chip Salzenberg               - a.k.a. -              <chip@pobox.com>
 "We have no fuel on board, plus or minus 8 kilograms."  -- NEAR tech

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2001-10-02 23:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-10-02 23:03 [PATCH] nfsd 2.4.10: unbloat filehandles for export points Chip Salzenberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox