Re: [PATCH] Intel 830 support for agpgart

[Christof Efkemann <chref@tzi.de>]

On Wed, 3 Oct 2001 04:52:57 +0200
David Weinehall <tao@acc.umu.se> wrote:

> On Tue, Oct 02, 2001 at 10:20:43PM -0400, Robert Love wrote:
> > On Tue, 2001-10-02 at 20:16, David Weinehall wrote:
> > > If the only differences between the different cards are the nr of
> > > aperture-sizes and the status-register settings, why not have a struct
> > > which contains all the valid cards, and use a scan-routine?!

There is already such a struct, agp_bridge_info, and a scan-routine,
agp_lookup_host_bridge.  These values could probably be added easily.
Although it would then be necessary for the other chipsets, too.

> Afaik, speed is not really an issue (it's not like you're going to
> notice a difference anyway, even if you had a struct with 100 different
> adapters in it.) As for reapproaching the size of the current
> implementation, the difference is that you get one single function that
> you don't have to change. You just add one single line to the struct
> for each adapter.

Even if it was slower it wouldn't really matter, as this is executed only
once during initialization.

> > There are only 3 possibilities right now (i830, i840, and everything
> > else).

And don't forget the i850 ;-)

-- 
Regards,
Christof Efkemann