From: Christoph Hellwig <hch@ns.caldera.de>
To: viro@math.psu.edu (Alexander Viro)
Cc: "Vladimir V. Saveliev" <vs@namesys.com>,
linux-kernel@vger.kernel.org, reiserfs-list@namesys.com,
Linus Torvalds <torvalds@transmeta.com>
Subject: Re: [PATCH] Re: bug? in using generic read/write functions to read/write block devices in 2.4.11-pre2
Date: Wed, 3 Oct 2001 23:56:19 +0200 [thread overview]
Message-ID: <200110032156.f93LuJb01378@ns.caldera.de> (raw)
In-Reply-To: <Pine.GSO.4.21.0110031643130.23558-100000@weyl.math.psu.edu>
Hi Al,
In article <Pine.GSO.4.21.0110031643130.23558-100000@weyl.math.psu.edu> you wrote:
> Moreover, ->release() for block_device also doesn't care for the junk
> we pass - it only uses inode->i_rdev. In all cases. And I'd rather
> see it them as
> int (*open)(struct block_device *bdev, int flags, int mode);
> int (*release)(struct block_device *bdev);
> int (*check_media_change)(struct block_device *bdev);
> int (*revalidate)(struct block_device *bdev);
> - that would make more sense than the current variant. They are block_device
> methods, not file or inode ones, after all.
How about starting 2.5 with that patch ones 2.4.11 is done? Linus?
Christoph
--
Of course it doesn't work. We've performed a software upgrade.
next prev parent reply other threads:[~2001-10-03 22:00 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-03 12:17 bug? in using generic read/write functions to read/write block devices in 2.4.11-pre2 Vladimir V. Saveliev
2001-10-03 13:16 ` [PATCH] " Alexander Viro
2001-10-03 16:18 ` Linus Torvalds
2001-10-03 21:43 ` Alexander Viro
2001-10-03 21:56 ` Christoph Hellwig [this message]
2001-10-03 22:51 ` Alexander Viro
2001-10-03 19:55 ` Whining about 2.5 (was Re: [PATCH] Re: bug? in using generic read/write functions to read/write block devices in 2.4.11-pre2) Rob Landley
2001-10-04 0:38 ` Rik van Riel
2001-10-03 22:27 ` Rob Landley
2001-10-04 20:53 ` Whining about 2.5 (was Re: [PATCH] Re: bug? in using generic read/write functions to read/write block devices in 2.4.11-pre2O Alan Cox
2001-10-04 23:59 ` Whining about NUMA. :) [Was whining about 2.5...] Rob Landley
2001-10-05 14:51 ` Alan Cox
2001-10-08 17:57 ` Martin J. Bligh
2001-10-08 18:10 ` Alan Cox
2001-10-08 18:20 ` Martin J. Bligh
2001-10-08 18:31 ` Alan Cox
2001-10-08 18:35 ` Jesse Barnes
2001-10-08 18:55 ` Martin J. Bligh
2001-10-08 17:48 ` Marcelo Tosatti
2001-10-08 19:20 ` Martin J. Bligh
2001-10-08 19:12 ` Jesse Barnes
2001-10-08 19:37 ` Peter Rival
2001-10-04 23:39 ` NUMA & classzones (was Whining about 2.5) Martin J. Bligh
2001-10-04 23:55 ` Rob Landley
2001-10-05 17:29 ` Martin J. Bligh
2001-10-06 1:44 ` Jesse Barnes
2001-10-04 21:02 ` Whining about 2.5 (was Re: [PATCH] Re: bug? in using generic read/write functions to read/write block devices in 2.4.11-pre2) Alan Cox
2001-10-03 21:09 ` Buffer cache confusion? Re: [reiserfs-list] bug? in using generic read/write functions to read/write block devices in 2.4.11-pre2 Eric Whiting
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200110032156.f93LuJb01378@ns.caldera.de \
--to=hch@ns.caldera.de \
--cc=linux-kernel@vger.kernel.org \
--cc=reiserfs-list@namesys.com \
--cc=torvalds@transmeta.com \
--cc=viro@math.psu.edu \
--cc=vs@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox